build: support shared v8 properly #2806

Closed
wants to merge 2 commits into
from

2 participants

@tchollingsworth

-don't pull in bundled v8 as a dependency when node_shared_v8==true
-use node_shared_v8_includes for v8.h and v8-debug.h

@tchollingsworth tchollingsworth build: support shared V8 properly
-don't pull in bundled v8 as a dependency when node_shared_v8==true
-use node_shared_v8_includes for v8.h and v8-debug.h
6a877fb
@bnoordhuis
Node.js Foundation member

Thomas, your patch looks good but it breaks when node_v8_shared == false:

$ make V=1
make -C out BUILDTYPE=Release
make[1]: Entering directory `/home/bnoordhuis/src/nodejs/master/out'
  flock /home/bnoordhuis/src/nodejs/master/out/Release/linker.lock g++ -pthread -rdynamic  -o /home/bnoordhuis/src/nodejs/master/out/Release/mksnapshot -Wl,--start-group /home/bnoordhuis/src/nodejs/master/out/Release/obj.target/mksnapshot/deps/v8/src/mksnapshot.o /home/bnoordhuis/src/nodejs/master/out/Release/obj.target/deps/v8/tools/gyp/libv8_base.a /home/bnoordhuis/src/nodejs/master/out/Release/obj.target/deps/v8/tools/gyp/libv8_nosnapshot.a -Wl,--end-group -lz -lv8
/usr/bin/ld.bfd.real: cannot find -lv8
collect2: ld returned 1 exit status
make[1]: *** [/home/bnoordhuis/src/nodejs/master/out/Release/mksnapshot] Error 1
make[1]: Leaving directory `/home/bnoordhuis/src/nodejs/master/out'
make: *** [node] Error 2
@tchollingsworth

Oops, sorry about that. I did test it without shared v8 but it succeeded on my system because there was a still a V8 shared library to link against. :-/

Should be good now.

@bnoordhuis
Node.js Foundation member

Merged in 3d1b670, thanks!

@bnoordhuis bnoordhuis closed this Feb 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment