Add `process.config` #2928

Closed
wants to merge 6 commits into
from

Projects

None yet

2 participants

This pull adds a process.config object. It looks like:

> process.config
{ target_defaults: 
   { cflags: [],
     default_configuration: 'Release',
     defines: [],
     include_dirs: [],
     libraries: [] },
  variables: 
   { host_arch: 'x64',
     node_install_npm: true,
     node_install_waf: true,
     node_prefix: '',
     node_shared_v8: false,
     node_shared_zlib: false,
     node_use_dtrace: false,
     node_use_openssl: false,
     strict_aliasing: true,
     target_arch: 'x64',
     v8_use_snapshot: true } }

Relatively straightforward changes, though I am sort of abusing js2c by stuffing the config.gypi file in there. But hey, it works well! Cheers!

Added bonus: I was able to update the tools/installer.js file to use this new process.config to get the node_prefix, rather than the hacky setup that was there.

Owner

I like it. I was going to ask you to initialize process.config lazily but it doesn't seem to make an appreciable difference on benchmark/startup.js. Can you squash it into a couple of logical commits?

TooTallNate added some commits Mar 14, 2012
@TooTallNate TooTallNate js2c: fix to support files other than ones ending with 2 char extensions
Previously this was basically hard-coded for *.js files, but now we
need to include the 'config.gypi' file in there as well.
1d1f175
@TooTallNate TooTallNate node.gyp: include the config.gypi file in the js2c inputs list 585421e
@TooTallNate TooTallNate process: add `process.config`
This is the JS representation of the `config.gypi` file that was used when
compiling node. With this information, you can tell whether the current node
binary has shared or static dependencies, or any other configuration options
that may have been used.
293d9a2
@TooTallNate TooTallNate docs: add documentation for `process.config` 581a964
@TooTallNate TooTallNate install: update install.js to use `process.config`
Now that the node_prefix is available from within node, we can use it :)
e1bf2ba

Ok @bnoordhuis, squashed into 5 logical commits.

So this breaks the windows build, I'll have to address that before merging.

Can @igorzi or @piscisaureus check out this? It'll need to be committed before process.config: TooTallNate@joyent:master...windows-configure

@TooTallNate TooTallNate added a commit to TooTallNate/node that referenced this pull request Mar 15, 2012
@TooTallNate TooTallNate vcbuild: run the 'configure' script in vcbuild.bat
So that a 'config.gypi' file gets generated, which is
required for the `process.config` object (see #2928).
7469fb4
@TooTallNate TooTallNate added a commit that referenced this pull request Mar 15, 2012
@TooTallNate TooTallNate vcbuild: run the 'configure' script in vcbuild.bat
So that a 'config.gypi' file gets generated, which is
required for the `process.config` object (see #2928).
dc75232

Merged in commits leading up to 7cb0f5f.

@joaocgreis joaocgreis pushed a commit to janeasystems/node-v0.x-archive that referenced this pull request Feb 12, 2016
@Trott Trott test: fix flaky test-http-regr-gh-2928
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: nodejs/node#4830
PR-URL: nodejs/node#5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2848f84
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @MylesBorins Trott + MylesBorins test: fix flaky test-http-regr-gh-2928
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: nodejs/node#4830
PR-URL: nodejs/node#5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
fdfe0b8
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @MylesBorins Trott + MylesBorins test: mark test-http-regr-gh-2928 flaky
`test-http-regr-gh-2928` is flay on SmartOS in CI.

Refs: nodejs/node#5264
PR-URL: nodejs/node#5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
f87b8f7
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @rvagg Trott + rvagg test: fix flaky test-http-regr-gh-2928
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: nodejs/node#4830
PR-URL: nodejs/node#5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
69c544f
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @rvagg Trott + rvagg test: mark test-http-regr-gh-2928 flaky
`test-http-regr-gh-2928` is flay on SmartOS in CI.

Refs: nodejs/node#5264
PR-URL: nodejs/node#5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
f5cc047
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @MylesBorins Trott + MylesBorins test: fix flaky test-http-regr-gh-2928
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: nodejs/node#4830
PR-URL: nodejs/node#5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
8be3afc
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 18, 2016
@Trott @MylesBorins Trott + MylesBorins test: mark test-http-regr-gh-2928 flaky
`test-http-regr-gh-2928` is flay on SmartOS in CI.

Refs: nodejs/node#5264
PR-URL: nodejs/node#5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
47e7c8c
@joaocgreis joaocgreis pushed a commit to janeasystems/node-v0.x-archive that referenced this pull request Feb 19, 2016
@Trott @jasnell Trott + jasnell test: mark test-http-regr-gh-2928 flaky
`test-http-regr-gh-2928` is flay on SmartOS in CI.

Refs: nodejs/node#5264
PR-URL: nodejs/node#5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
5778f2b
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Mar 4, 2016
@Trott @Fishrock123 Trott + Fishrock123 test: retry on known SmartOS bug
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: nodejs/node#5445
Refs: nodejs/node#3941
PR-URL: nodejs/node#5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
d1a82c6
@joaocgreis joaocgreis pushed a commit to janeasystems/node-v0.x-archive that referenced this pull request Mar 9, 2016
@Trott Trott test: retry on known SmartOS bug
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: nodejs/node#5445
Refs: nodejs/node#3941
PR-URL: nodejs/node#5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
8592697
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Mar 9, 2016
@Trott @MylesBorins Trott + MylesBorins test: fix flaky test-http-regr-gh-2928
Fix flaky test-http-regr-gh-2928 that has been failing on Raspberry Pi
devices in CI.

Fixes: nodejs/node#4830
PR-URL: nodejs/node#5154
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
8b99e2d
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Mar 9, 2016
@Trott @MylesBorins Trott + MylesBorins test: mark test-http-regr-gh-2928 flaky
`test-http-regr-gh-2928` is flay on SmartOS in CI.

Refs: nodejs/node#5264
PR-URL: nodejs/node#5280
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
04b1b0a
@gibfahn gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Mar 23, 2016
@Trott @MylesBorins Trott + MylesBorins test: retry on known SmartOS bug
There is a known issue with SmartOS that is generally worked around
in `tools/test.py`. However, a more robust workaround is required for
some tests that open many network connections.

`test-http-regr-gh-2928` is one such test.

Fixes: nodejs/node#5445
Refs: nodejs/node#3941
PR-URL: nodejs/node#5454
Reviewed-By: Fedor Indutny <fedor@indutny.com>
b4ef644
@gibfahn gibfahn pushed a commit to ibmruntimes/node that referenced this pull request May 6, 2016
@Trott Trott test: unmark test-http-regr-gh-2928 as flaky
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in nodejs/node#5454. This
change removes its flaky designation in sequential.status.

PR-URL: nodejs/node#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
330ea76
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request May 17, 2016
@Trott @evanlucas Trott + evanlucas test: unmark test-http-regr-gh-2928 as flaky
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in nodejs/node#5454. This
change removes its flaky designation in sequential.status.

PR-URL: nodejs/node#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
8c434e6
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Jul 13, 2016
@Trott @MylesBorins Trott + MylesBorins test: unmark test-http-regr-gh-2928 as flaky
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in nodejs/node#5454. This
change removes its flaky designation in sequential.status.

PR-URL: nodejs/node#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
9e8addd
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Jul 18, 2016
@Trott @MylesBorins Trott + MylesBorins test: unmark test-http-regr-gh-2928 as flaky
The flakiness issue for test-http-regr-gh-2928 on SmartOS was resolved
in late February in nodejs/node#5454. This
change removes its flaky designation in sequential.status.

PR-URL: nodejs/node#6540
Reviewed-By: James M Snell <jasnell@gmail.com>
3aef9b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment