V0.6 #3115

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Leopard build fixes.

@bnoordhuis bnoordhuis commented on the diff Apr 16, 2012

src/platform_darwin_proctitle.cc
namespace node {
+extern char * process_title;
@bnoordhuis

bnoordhuis Apr 16, 2012

Owner

It's quite surprising that this even compiled on newer versions of OS X. Compilers and linkers are way too lenient these days. :-)

EDIT: Right, this file is excluded from the build, that's why.

@bnoordhuis bnoordhuis commented on the diff Apr 16, 2012

src/platform_darwin.cc
@@ -38,14 +38,14 @@
#include <netinet/in.h>
#include <arpa/inet.h>
#include <ifaddrs.h>
-
-
+#include <errno.h>
@bnoordhuis

bnoordhuis Apr 16, 2012

Owner

What do you need <errno.h> for?

@jdduncan

jdduncan Apr 16, 2012

Without it I get this:

../src/platform_darwin.cc: In static member function ‘static v8::Handlev8::Value node::Platform::GetInterfaceAddresses()’:
../src/platform_darwin.cc:167: error: ‘errno’ was not declared in this scope

@bnoordhuis bnoordhuis commented on the diff Apr 16, 2012

@@ -443,6 +443,8 @@ def configure(conf):
if sys.platform.startswith("darwin"):
# used by platform_darwin_*.cc
conf.env.append_value('LINKFLAGS', ['-framework','Carbon'])
+ # define _DARWIN_C_SOURCE to enable SUSv3 UNIX 2003 compatiblity
+ conf.env.append_value('CPPFLAGS', '-D_DARWIN_C_SOURCE')
@bnoordhuis

bnoordhuis Apr 16, 2012

Owner

My bad. This was already fixed in master but I never back-ported the patch. Fixed (in v0.6) in 3f42612.

Owner

bnoordhuis commented Apr 16, 2012

@jdduncan: Two questions:

  1. Can you revert the changes to node.gyp? It's not used in v0.6 and the platform files have been removed in master.
  2. Can you confirm that the current v0.6 HEAD compiles without -D_DARWIN_C_SOURCE? If so, can you revert that part of the wscript?

Last point of order, can you sign the CLA? Thanks.

Owner

bnoordhuis commented May 15, 2012

Sorry, I'm going to close this, it's stale. If you're interested in getting these changes landed, please open a new PR.

bnoordhuis closed this May 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment