Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes #3179 http.js leak while using http.get/request #3181
Made a small changes that could means big change for anyone using http.get/request (like @mikeal request)
We were previously using self.on('response') on ClientRequest, meaning that any ClientRequest would stay in memory even when response is emitted.
So I changed that with .once since we should not get more than one reponse for a particular ClientRequest right ?
I hope I'm not mistaking. Tell me.
In #3179 I have attached a test file and some insights on memory usage from various node versions.