This repository has been archived by the owner. It is now read-only.

punycode: Update to v1.0.0 (properly this time) #3359

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Follow-up to 483edbd, which incorrectly updated the version number, but not the API, causing a mismatch between the documentation (a2fcc47) and the actual code.

punycode: Update to v1.0.0
Follow-up to 483edbd, which incorrectly updated the version number,
but not the API, causing a mismatch between the documentation (a2fcc47)
and the actual code.

koichik commented Jun 2, 2012

@isaacs @bnoordhuis - Can we merge this? I do not know why #2456 was not merged in v0.6, accident or intentional? #2456 (also this patch) changes the API, but the old API has never been documented. If we cannot merge this, I think that #2824 should be reverted (Node v0.6 continues to use punycode.js v0.2.1).

Member

bnoordhuis commented Jun 2, 2012

I do not know why #2456 was not merged in v0.6, accident or intentional?

Intentional. Only bug fixes should go in v0.6. 483edbd (from #2824) shouldn't have been landed in v0.6.

koichik commented Jun 3, 2012

@bnoordhuis - Okay, thanks.

@isaacs - Can 483edbd (#2824) be reverted?

isaacs commented Jun 4, 2012

@koichik Yes, 483edbd should be reverted. Thanks.

@koichik koichik closed this in 0742f56 Jun 5, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.