This repository has been archived by the owner. It is now read-only.

msi: cleanup wix project files #3360

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

japj commented Jun 1, 2012

The current wix project files do some manual processing and generation which
wix supports doing out of the box. This patch will use the HeatDirectory task
to generate the npm.wxs file and use the auto GUID generation. I also changed
the msi filename generation to include the version number to match the
currently used name for released msi files.

Note: I did not test the msi signing part

Member

piscisaureus commented Jun 2, 2012

@japj Looks, good. However, now that we're at it, could you change the msi filename to also include the target architecture? If it helps, I just landed 9fe39ed which makes x64 installers work properly.

msi: cleanup wix project files
The current wix project files do some manual processing and generation which
wix supports doing out of the box. This patch will use the HeatDirectory task
to generate the npm.wxs file and use the auto GUID generation. I also changed
the msi filename generation to include the version number to match the
currently used name for released msi files.

japj commented Jun 2, 2012

updated the patch
now you'll get node-v0.7.10-x86.msi and node-v0.7.10-x64.msi on current master

richardlau pushed a commit to ibmruntimes/node that referenced this pull request Nov 5, 2015

doc: label v4.2.1 as LTS in changelog heading
PR-URL: #3360
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.