This repository has been archived by the owner. It is now read-only.

Address issue #591 #3398

Closed
wants to merge 53 commits into
from

Conversation

Projects
None yet
5 participants

mattness commented Jun 9, 2012

I've attempted to clean up all the issues reported by cpplint.py to address #591. The vast majority of these changes are formatting-only. But there are a handful that could modify behavior (sprintf => snprintf comes to mind).

I've built these changes and run the tests on Arch (gcc 4.7.0), Ubuntu 12.04 (gcc 4.6.3), OS X 10.7.4, Solaris 11, and Windows 7. On all platforms, the test results matched those of running the tests against master (284816e).

I couldn't decide whether to do these as separate commits or as one giant commit. I went with separate commits, but would be happy to squash them into one if that is preferred.

Matt Gollob added some commits Jun 2, 2012

Update 'include_dirs' in node.gyp to use <(DEPTH) instead of src
Using <(DEPTH), which evaluates to the repo root, allows us to fix the
"Include the directory when naming .h files" linter complaint
Fix linter complaints in src/cares_wrap.cc
src/cares_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/cares_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/cares_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/cares_wrap.cc:27:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:30:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:32:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:38:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:39:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:44:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/cares_wrap.cc:45:  Found C system header after other header. Should be: cares_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/cares_wrap.cc:604:  Using C-style cast.  Use reinterpret_cast<GetAddrInfoReqWrap*>(...) instead  [readability/casting] [4]
src/cares_wrap.cc:639:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/cares_wrap.cc:661:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/cares_wrap.cc:762:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/fs_event_wrap.cc
src/fs_event_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/fs_event_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/fs_event_wrap.cc:25:  Found C system header after other header. Should be: fs_event_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/fs_event_wrap.cc:27:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/fs_event_wrap.cc:34:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/fs_event_wrap.cc:40:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/fs_event_wrap.cc:41:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/fs_event_wrap.cc:53:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/fs_event_wrap.cc:102:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/fs_event_wrap.cc:141:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/fs_event_wrap.cc:144:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/fs_event_wrap.cc:147:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/fs_event_wrap.cc:147:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/fs_event_wrap.cc:155:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/fs_event_wrap.cc:179:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/handle_wrap.cc and src/handle_wrap.h
src/handle_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/handle_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/handle_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/handle_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_HANDLE_WRAP_H_  [build/header_guard] [5]
src/handle_wrap.h:77:  #endif line should be "#endif  // SRC_HANDLE_WRAP_H_"  [build/header_guard] [5]
src/handle_wrap.h:25:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/ngx-queue.h
src/ngx-queue.h:7:  #ifndef header guard has wrong style, please use: SRC_NGX_QUEUE_H_  [build/header_guard] [5]
src/ngx-queue.h:106:  #endif line should be "#endif  // SRC_NGX_QUEUE_H_"  [build/header_guard] [5]
src/ngx-queue.h:99:  Using C-style cast.  Use reinterpret_cast<type *>(...) instead  [readability/casting] [4]
Fix linter complaints in src/node.cc and src/node.h
src/node.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:28:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:33:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:34:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:35:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:36:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:37:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:39:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:43:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:44:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:46:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:48:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:49:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:51:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:55:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:56:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:57:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:60:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:61:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:64:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:68:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:69:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:74:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:75:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:76:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:77:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:81:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:82:  Include the directory when naming .h files  [build/include] [4]
src/node.cc:84:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node.cc:87:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.cc:128:  Missing spaces around =  [whitespace/operators] [4]
src/node.cc:180:  Extra space before ( in function call  [whitespace/parens] [4]
src/node.cc:181:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/node.cc:186:  Extra space before ( in function call  [whitespace/parens] [4]
src/node.cc:187:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/node.cc:193:  Using C-style cast.  Use reinterpret_cast<uv_idle_t*>(...) instead  [readability/casting] [4]
src/node.cc:211:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node.cc:213:  Should have a space between // and comment  [whitespace/comments] [4]
src/node.cc:217:  Should have a space between // and comment  [whitespace/comments] [4]
src/node.cc:224:  Should have a space between // and comment  [whitespace/comments] [4]
src/node.cc:258:  Using C-style cast.  Use reinterpret_cast<uv_idle_t*>(...) instead  [readability/casting] [4]
src/node.cc:265:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:294:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node.cc:619:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node.cc:869:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:939:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.cc:1006:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:1065:  If you can, use sizeof(errno_buf) instead of 100 as the 2nd arg to snprintf.  [runtime/printf] [3]
src/node.cc:1123:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1123:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:1211:  Extra space before ( in function call  [whitespace/parens] [4]
src/node.cc:1211:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.cc:1265:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.cc:1412:  Missing space before ( in if(  [whitespace/parens] [5]
src/node.cc:1418:  Missing space before ( in if(  [whitespace/parens] [5]
src/node.cc:1538:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1552:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/node.cc:1564:  Should have a space between // and comment  [whitespace/comments] [4]
src/node.cc:1567:  Should have a space between // and comment  [whitespace/comments] [4]
src/node.cc:1717:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1718:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1738:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1765:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node.cc:1803:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.cc:1817:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node.cc:1878:  If you can, use sizeof(buf) instead of 1024 as the 2nd arg to snprintf.  [runtime/printf] [3]
src/node.cc:1905:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node.cc:1927:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:1943:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:1952:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node.cc:2016:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2087:  Extra space before )  [whitespace/parens] [2]
src/node.cc:2090:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2090:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:2126:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node.cc:2264:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2346:  Extra space before ( in function call  [whitespace/parens] [4]
src/node.cc:2401:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node.cc:2492:  All parameters should be named in a function  [readability/function] [3]
src/node.cc:2521:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2584:  Using C-style cast.  Use reinterpret_cast<void*>(...) instead  [readability/casting] [4]
src/node.cc:2601:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node.cc:2664:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
src/node.cc:2678:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2730:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2739:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2773:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2775:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.cc:2835:  Missing space before ( in for(  [whitespace/parens] [5]
src/node.cc:2839:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
src/node.cc:2844:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node.cc:2846:  Missing space before ( in for(  [whitespace/parens] [5]
src/node.h:61:  Include the directory when naming .h files  [build/include] [4]
src/node.h:62:  Include the directory when naming .h files  [build/include] [4]
src/node.h:63:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.h:64:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.h:65:  Found C system header after other header. Should be: node.h, c system, c++ system, other.  [build/include_order] [4]
src/node.h:67:  Include the directory when naming .h files  [build/include] [4]
src/node.h:111:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node.h:119:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node.h:131:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.h:132:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.h:132:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node.h:153:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node.h:215:  Extra space before ( in function call  [whitespace/parens] [4]
Fix linter complaints in src/node_buffer.cc and src/node_buffer.h
src/node_buffer.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.cc:28:  Found C system header after other header. Should be: node_buffer.h, c system, c++ system, other.  [build/include_order] [4]
src/node_buffer.cc:29:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.cc:29:  Found C system header after other header. Should be: node_buffer.h, c system, c++ system, other.  [build/include_order] [4]
src/node_buffer.cc:30:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.cc:30:  Found C system header after other header. Should be: node_buffer.h, c system, c++ system, other.  [build/include_order] [4]
src/node_buffer.cc:33:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.cc:33:  Found C system header after other header. Should be: node_buffer.h, c system, c++ system, other.  [build/include_order] [4]
src/node_buffer.cc:37:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:41:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_buffer.cc:95:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_buffer.cc:240:  Should have a space between // and comment  [whitespace/comments] [4]
src/node_buffer.cc:273:  Using C-style cast.  Use reinterpret_cast<uint16_t*>(...) instead  [readability/casting] [4]
src/node_buffer.cc:284:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:285:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:286:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:287:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:288:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:289:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:290:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:291:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:292:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:293:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:294:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:295:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:296:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:297:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:298:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:299:  Missing space after ,  [whitespace/comma] [3]
src/node_buffer.cc:314:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.cc:315:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.cc:343:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_buffer.cc:348:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_buffer.cc:356:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_buffer.cc:365:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_buffer.cc:384:  Using C-style cast.  Use static_cast<char>(...) instead  [readability/casting] [4]
src/node_buffer.cc:389:  Using C-style cast.  Use reinterpret_cast<void*>(...) instead  [readability/casting] [4]
src/node_buffer.cc:446:  Using C-style cast.  Use reinterpret_cast<void *>(...) instead  [readability/casting] [4]
src/node_buffer.cc:525:  Using C-style cast.  Use reinterpret_cast<uint16_t*>(...) instead  [readability/casting] [4]
src/node_buffer.cc:663:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/node_buffer.cc:703:  More than one command on the same line  [whitespace/newline] [4]
src/node_buffer.cc:708:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:719:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:753:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:754:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:755:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:756:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:757:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node_buffer.cc:759:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:761:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:762:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:763:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:764:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:765:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:776:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_buffer.cc:372:  Add #include <string> for string  [build/include_what_you_use] [4]
src/node_buffer.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_BUFFER_H_  [build/header_guard] [5]
src/node_buffer.h:134:  #endif line should be "#endif  // SRC_NODE_BUFFER_H_"  [build/header_guard] [5]
src/node_buffer.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.h:27:  Include the directory when naming .h files  [build/include] [4]
src/node_buffer.h:28:  Found C system header after other header. Should be: node_buffer.h, c system, c++ system, other.  [build/include_order] [4]
src/node_buffer.h:76:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/node_buffer.h💯  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.h:101:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.h:103:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_buffer.h:97:  Add #include <string> for string  [build/include_what_you_use] [4]
Fix linter complaints in src/node_constants.cc and src/node_constants.h
src/node_constants.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_constants.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_constants.cc:26:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:28:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:30:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:31:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:32:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:33:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:36:  Found C system header after other header. Should be: node_constants.h, c system, c++ system, other.  [build/include_order] [4]
src/node_constants.cc:41:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_constants.cc:992:  Small and focused functions are preferred: DefineConstants() has 705 non-comment lines (error triggered by exceeding 500 lines).  [readability/fn_size] [1]
src/node_constants.cc:994:  Small and focused functions are preferred: DefineConstants() has 705 non-comment lines (error triggered by exceeding 500 lines).  [readability/fn_size] [1]
src/node_constants.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_CONSTANTS_H_  [build/header_guard] [5]
src/node_constants.h:32:  #endif line should be "#endif  // SRC_NODE_CONSTANTS_H_"  [build/header_guard] [5]
src/node_constants.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_constants.h:26:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_crypto.cc and src/node_crypto.h
src/node_crypto.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:28:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.cc:30:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.cc:35:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.cc:37:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.cc:41:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.cc:43:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.cc:55:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:70:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_crypto.cc:93:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:95:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:97:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:182:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:188:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:194:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:231:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:260:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:261:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:339:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:371:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/node_crypto.cc:395:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:581:  Should have a space between // and comment  [whitespace/comments] [4]
src/node_crypto.cc:626:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_crypto.cc:650:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:670:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:673:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:681:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
src/node_crypto.cc:688:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:746:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:778:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:784:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:787:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:791:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:856:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node_crypto.cc:907:  Extra space before )  [whitespace/parens] [2]
src/node_crypto.cc:1018:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:1325:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:1354:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1354:  Missing spaces around <  [whitespace/operators] [3]
src/node_crypto.cc:1363:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/node_crypto.cc:1363:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/node_crypto.cc:1548:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:1811:  Missing space before ( in for(  [whitespace/parens] [5]
src/node_crypto.cc:1917:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1920:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1921:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1924:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:1925:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1934:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1938:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_crypto.cc:1939:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1943:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1946:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1950:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1950:  Missing spaces around <  [whitespace/operators] [3]
src/node_crypto.cc:1952:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:1957:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1959:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1959:  Missing spaces around <  [whitespace/operators] [3]
src/node_crypto.cc:1962:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1964:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:1973:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:1992:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:1997:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2022:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2049:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2064:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2086:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2097:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2124:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2126:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/node_crypto.cc:2135:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2143:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2157:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2163:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2180:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2184:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2185:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2196:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2202:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2207:  Missing spaces around ==  [whitespace/operators] [3]
src/node_crypto.cc:2208:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2221:  Missing spaces around !=  [whitespace/operators] [3]
src/node_crypto.cc:2221:  Missing space before {  [whitespace/braces] [5]
src/node_crypto.cc:2222:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/node_crypto.cc:2223:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2228:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2230:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2235:  Missing spaces around !=  [whitespace/operators] [3]
src/node_crypto.cc:2235:  Missing space before {  [whitespace/braces] [5]
src/node_crypto.cc:2279:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
src/node_crypto.cc:2306:  Missing spaces around !=  [whitespace/operators] [3]
src/node_crypto.cc:2306:  Missing space before {  [whitespace/braces] [5]
src/node_crypto.cc:2307:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2308:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2309:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2313:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2315:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2332:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2333:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_crypto.cc:2337:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2350:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_crypto.cc:2358:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2359:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_crypto.cc:2380:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2385:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2416:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2448:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2473:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2475:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2485:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2498:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2499:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2510:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2520:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2525:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2536:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2537:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2539:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/node_crypto.cc:2548:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2556:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2570:  Missing space after ,  [whitespace/comma] [3]
src/node_crypto.cc:2576:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2633:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2634:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2637:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2637:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
src/node_crypto.cc:2647:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
src/node_crypto.cc:2663:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2664:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2669:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2674:  Missing spaces around ==  [whitespace/operators] [3]
src/node_crypto.cc:2675:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2680:  Missing spaces around !=  [whitespace/operators] [3]
src/node_crypto.cc:2682:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2683:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2683:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node_crypto.cc:2693:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node_crypto.cc:2694:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:2694:  Missing spaces around <  [whitespace/operators] [3]
src/node_crypto.cc:2696:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2697:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2709:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_crypto.cc:2737:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:2753:  Missing spaces around !=  [whitespace/operators] [3]
src/node_crypto.cc:2755:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2756:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2756:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node_crypto.cc:2759:  Missing spaces around =  [whitespace/operators] [4]
src/node_crypto.cc:2761:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2774:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2778:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2800:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2816:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2824:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_crypto.cc:2845:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2867:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2875:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2875:  Mismatching spaces inside () in if  [whitespace/parens] [5]
src/node_crypto.cc:2908:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2914:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:2914:  Mismatching spaces inside () in if  [whitespace/parens] [5]
src/node_crypto.cc:2929:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:2972:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2976:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:2992:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3005:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3007:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3023:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3054:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3074:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3127:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3131:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3147:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3161:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3163:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3171:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_crypto.cc:3189:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3191:  Extra space after ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3191:  Extra space before )  [whitespace/parens] [2]
src/node_crypto.cc:3205:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3245:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3266:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3284:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:3292:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3331:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3335:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3350:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3365:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3367:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3385:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3398:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3440:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3441:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3455:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3497:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3503:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_crypto.cc:3518:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3535:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3548:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.cc:3553:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node_crypto.cc:3563:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
src/node_crypto.cc:3568:  Using C-style cast.  Use reinterpret_cast<char **>(...) instead  [readability/casting] [4]
src/node_crypto.cc:3584:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3588:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_crypto.cc:3599:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_crypto.cc:3678:  Missing space before ( in while(  [whitespace/parens] [5]
src/node_crypto.cc:4180:  Using C-style cast.  Use reinterpret_cast<pbkdf2_req*>(...) instead  [readability/casting] [4]
src/node_crypto.cc:4197:  Using C-style cast.  Use reinterpret_cast<pbkdf2_req*>(...) instead  [readability/casting] [4]
src/node_crypto.cc:4316:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/node_crypto.cc:4329:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_crypto.cc:4329:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:4367:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:4378:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
src/node_crypto.cc:4384:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/node_crypto.cc:4384:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/node_crypto.cc:4441:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/node_crypto.cc:4441:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/node_crypto.cc:4476:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
src/node_crypto.cc:402:  Add #include <string> for string  [build/include_what_you_use] [4]
src/node_crypto.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.h:27:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.h:28:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.h:30:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:31:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:32:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:33:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:34:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:35:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:36:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:37:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:38:  Found C system header after other header. Should be: node_crypto.h, c system, c++ system, other.  [build/include_order] [4]
src/node_crypto.h:41:  Include the directory when naming .h files  [build/include] [4]
src/node_crypto.h:57:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node_crypto.h:147:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto.h:188:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
src/node_crypto.h:189:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
src/node_crypto.h:190:  Weird number of spaces at line-start.  Are you using a 2-space indent?  [whitespace/indent] [3]
Fix linter complaints in src/node_extensions.cc and src/node_extensio…
…ns.h

src/node_extensions.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_extensions.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_extensions.cc:36:  Include the directory when naming .h files  [build/include] [4]
src/node_extensions.cc:47:  Include the directory when naming .h files  [build/include] [4]
src/node_extensions.cc:47:  "node_extensions.h" already included at src/node_extensions.cc:36  [build/include] [4]
src/node_extensions.cc:52:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_extensions.cc:68:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_extensions.h:0:  No #ifndef header guard found, suggested CPP variable is: SRC_NODE_EXTENSIONS_H_  [build/header_guard] [5]
Fix linter complaints in src/node_file.cc and src/node_file.h
src/node_file.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_file.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_file.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_file.cc:28:  Include the directory when naming .h files  [build/include] [4]
src/node_file.cc:30:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:31:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:32:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:33:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:34:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:35:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:36:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:39:  Found C system header after other header. Should be: node_file.h, c system, c++ system, other.  [build/include_order] [4]
src/node_file.cc:44:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_file.cc:46:  Missing space after ,  [whitespace/comma] [3]
src/node_file.cc:55:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/node_file.cc:74:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_file.cc:78:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_file.cc:91:  Using C-style cast.  Use reinterpret_cast<FSReqWrap*>(...) instead  [readability/casting] [4]
src/node_file.cc:242:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_file.cc:365:  Using C-style cast.  Use reinterpret_cast<NODE_STAT_STRUCT*>(...) instead  [readability/casting] [4]
src/node_file.cc:381:  Using C-style cast.  Use reinterpret_cast<NODE_STAT_STRUCT*>(...) instead  [readability/casting] [4]
src/node_file.cc:398:  Using C-style cast.  Use reinterpret_cast<NODE_STAT_STRUCT*>(...) instead  [readability/casting] [4]
src/node_file.cc:467:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/node_file.cc:479:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node_file.cc:718:  Using C-style cast.  Use reinterpret_cast<char*>(...) instead  [readability/casting] [4]
src/node_file.cc:800:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_file.cc:806:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_file.cc:821:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_file.cc:827:  Missing space before ( in if(  [whitespace/parens] [5]
src/node_file.cc:962:  Should have a space between // and comment  [whitespace/comments] [4]
src/node_file.cc:966:  Should have a space between // and comment  [whitespace/comments] [4]
src/node_file.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_FILE_H_  [build/header_guard] [5]
src/node_file.h:38:  #endif line should be "#endif  // SRC_NODE_FILE_H_"  [build/header_guard] [5]
src/node_file.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_file.h:26:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_http_parser.cc and src/node_http_pa…
…rser.h

src/node_http_parser.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.cc:28:  Found C system header after other header. Should be: node_http_parser.h, c system, c++ system, other.  [build/include_order] [4]
src/node_http_parser.cc:30:  Found C system header after other header. Should be: node_http_parser.h, c system, c++ system, other.  [build/include_order] [4]
src/node_http_parser.cc:34:  Found C system header after other header. Should be: node_http_parser.h, c system, c++ system, other.  [build/include_order] [4]
src/node_http_parser.cc:50:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_http_parser.cc:85:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_http_parser.cc:86:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_http_parser.cc:87:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_http_parser.cc:88:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_http_parser.cc:89:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_http_parser.cc:101:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/node_http_parser.cc:153:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node_http_parser.cc:184:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/node_http_parser.cc:185:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/node_http_parser.cc:220:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_http_parser.cc:236:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/node_http_parser.cc:257:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/node_http_parser.cc:257:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/node_http_parser.cc:326:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_http_parser.cc:433:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/node_http_parser.cc:492:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/node_http_parser.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_HTTP_PARSER_H_  [build/header_guard] [5]
src/node_http_parser.h:35:  #endif line should be "#endif  // SRC_NODE_HTTP_PARSER_H_"  [build/header_guard] [5]
src/node_http_parser.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.h:27:  Include the directory when naming .h files  [build/include] [4]
src/node_http_parser.h:32:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
Fix linter complaints in src/node_crypto_groups.h
src/node_crypto_groups.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
src/node_crypto_groups.h:0:  No #ifndef header guard found, suggested CPP variable is: SRC_NODE_CRYPTO_GROUPS_H_  [build/header_guard] [5]
src/node_crypto_groups.h:377:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:378:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:379:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:380:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:381:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:382:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:383:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:384:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_crypto_groups.h:386:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Fix linter complaints in src/node_dtrace.cc and src/node_dtrace.h
src/node_dtrace.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_dtrace.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node_dtrace.cc:50:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_dtrace.cc:151:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node_dtrace.cc:172:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node_dtrace.cc:323:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_dtrace.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_DTRACE_H_  [build/header_guard] [5]
src/node_dtrace.h:82:  #endif line should be "#endif  // SRC_NODE_DTRACE_H_"  [build/header_guard] [5]
src/node_dtrace.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_dtrace.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_dtrace.h:29:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node_dtrace.h:39:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:40:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:41:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:42:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:46:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:47:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:64:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:65:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:66:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:67:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:68:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:69:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:70:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:71:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_dtrace.h:73:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_dtrace.h:79:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
Fix linter complaints in src/node_internals.h
src/node_internals.h:99:  #endif line should be "#endif  // SRC_NODE_INTERNALS_H_"  [build/header_guard] [5]
src/node_internals.h:27:  Include the directory when naming .h files  [build/include] [4]
src/node_internals.h:34:  Found C system header after other header. Should be: node_internals.h, c system, c++ system, other.  [build/include_order] [4]
src/node_internals.h:49:  Using C-style cast.  Use reinterpret_cast<char *>(...) instead  [readability/casting] [4]
src/node_internals.h:54:  Using C-style cast.  Use reinterpret_cast<type *>(...) instead  [readability/casting] [4]
src/node_internals.h:97:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_internals.h:99:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/node_io_watcher.cc and src/node_io_watch…
…er.h

src/node_io_watcher.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_io_watcher.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_io_watcher.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/node_io_watcher.cc:27:  Found C system header after other header. Should be: node_io_watcher.h, c system, c++ system, other.  [build/include_order] [4]
src/node_io_watcher.cc:31:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_io_watcher.cc:49:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_io_watcher.cc:112:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_io_watcher.cc:120:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_io_watcher.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_IO_WATCHER_H_  [build/header_guard] [5]
src/node_io_watcher.h:63:  #endif line should be "#endif  // SRC_NODE_IO_WATCHER_H_"  [build/header_guard] [5]
src/node_io_watcher.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_io_watcher.h:43:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
Fix linter complaints in src/node_main.cc
src/node_main.cc:22:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_object_wrap.h
src/node_object_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_OBJECT_WRAP_H_  [build/header_guard] [5]
src/node_object_wrap.h:115:  #endif line should be "#endif  // SRC_NODE_OBJECT_WRAP_H_"  [build/header_guard] [5]
src/node_object_wrap.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_object_wrap.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_object_wrap.h:27:  Found C system header after other header. Should be: node_object_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/node_object_wrap.h:33:  Extra space after ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:33:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:38:  Extra space after ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:50:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:57:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_object_wrap.h:60:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:69:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:101:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_object_wrap.h:105:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_object_wrap.h:31:  The class NODE_EXTERN probably needs a virtual destructor due to having virtual method(s), one declared at line 93.  [runtime/virtual] [4]
src/node_object_wrap.h:114:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_object_wrap.h:115:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/node_os.cc and src/node_os.h
src/node_os.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_os.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_os.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/node_os.cc:28:  Found C system header after other header. Should be: node_os.h, c system, c++ system, other.  [build/include_order] [4]
src/node_os.cc:29:  Found C system header after other header. Should be: node_os.h, c system, c++ system, other.  [build/include_order] [4]
src/node_os.cc:32:  Found C system header after other header. Should be: node_os.h, c system, c++ system, other.  [build/include_order] [4]
src/node_os.cc:36:  Found C system header after other header. Should be: node_os.h, c system, c++ system, other.  [build/include_order] [4]
src/node_os.cc:37:  Found C system header after other header. Should be: node_os.h, c system, c++ system, other.  [build/include_order] [4]
src/node_os.cc:42:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_os.cc:52:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_os.cc:54:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_os.cc:72:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_os.cc:88:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_os.cc:96:  Never use sprintf.  Use snprintf instead.  [runtime/printf] [5]
src/node_os.cc:97:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_os.cc:133:  Missing space after ,  [whitespace/comma] [3]
src/node_os.cc:217:  Missing space after ,  [whitespace/comma] [3]
src/node_os.cc:231:  Tab found; better to use spaces  [whitespace/tab] [1]
src/node_os.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_OS_H_  [build/header_guard] [5]
src/node_os.h:38:  #endif line should be "#endif  // SRC_NODE_OS_H_"  [build/header_guard] [5]
src/node_os.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_os.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_os.h:31:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/node_os.h:32:  Extra space before ( in function call  [whitespace/parens] [4]
Fix linter complaints in src/node_root_certs.h
src/node_root_certs.h:30:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:31:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:32:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:33:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:34:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:35:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:36:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:37:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:43:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:44:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:45:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:46:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:47:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:48:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:49:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:50:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:51:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:52:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:58:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:59:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:60:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:61:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:62:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:63:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:64:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:65:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:66:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:67:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:68:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:69:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:70:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:71:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:77:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:78:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:79:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:80:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:81:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:82:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:83:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:84:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:85:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:86:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:87:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:88:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:89:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:95:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:96:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:97:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:98:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:99:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:100:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:101:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:102:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:103:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:104:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:105:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:106:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:107:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:108:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:114:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:115:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:116:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:117:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:118:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:119:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:120:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:121:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:122:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:123:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:124:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:125:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:126:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:127:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:133:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:134:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:135:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:136:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:137:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:138:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:139:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:140:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:141:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:142:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:143:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:144:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:145:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:146:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:152:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:153:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:154:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:155:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:156:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:157:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:158:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:159:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:160:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:161:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:162:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:163:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:164:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:165:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:171:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:172:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:173:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:174:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:175:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:176:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:177:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:178:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:179:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:180:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:186:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:187:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:188:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:189:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:190:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:191:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:192:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:193:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:194:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:195:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:201:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:202:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:203:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:204:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:205:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:206:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:207:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:208:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:209:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:210:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:216:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:217:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:218:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:219:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:220:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:221:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:222:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:223:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:224:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:225:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:226:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:227:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:228:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:234:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:235:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:236:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:237:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:238:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:239:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:240:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:241:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:242:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:243:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:244:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:245:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:246:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:252:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:253:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:254:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:255:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:256:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:257:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:258:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:259:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:260:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:261:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:262:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:263:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:264:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:270:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:271:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:272:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:273:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:274:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:275:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:276:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:277:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:278:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:279:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:280:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:281:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:282:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:288:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:289:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:290:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:291:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:292:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:293:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:294:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:295:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:296:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:297:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:298:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:299:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:300:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:301:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:302:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:308:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:309:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:310:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:311:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:312:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:313:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:314:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:315:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:316:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:317:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:318:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:319:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:320:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:321:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:322:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:323:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:329:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:330:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:331:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:332:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:333:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:334:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:335:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:336:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:337:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:338:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:339:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:340:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:341:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:347:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:348:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:349:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:350:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:351:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:352:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:353:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:354:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:355:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:356:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:357:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:358:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:359:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:365:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:366:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:367:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:368:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:369:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:370:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:371:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:372:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:373:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:374:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:375:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:376:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:377:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:383:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:384:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:385:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:386:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:387:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:388:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:389:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:390:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:391:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:392:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:393:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:394:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:395:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:396:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:397:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:398:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:399:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:400:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:406:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:407:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:408:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:409:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:410:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:411:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:412:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:413:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:414:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:415:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:416:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:417:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:418:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:419:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:420:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:421:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:422:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:423:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:429:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:430:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:431:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:432:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:433:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:434:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:435:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:436:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:437:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:438:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:439:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:440:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:441:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:442:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:443:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:444:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:445:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:446:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:452:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:453:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:454:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:455:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:456:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:457:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:458:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:459:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:460:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:461:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:462:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:463:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:464:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:465:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:466:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:467:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:468:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:469:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:475:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:476:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:477:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:478:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:479:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:480:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:481:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:482:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:483:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:484:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:485:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:486:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:487:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:488:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:489:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:490:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:491:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:492:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:493:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:494:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:495:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:501:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:502:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:503:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:504:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:505:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:506:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:507:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:508:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:509:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:510:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:511:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:512:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:513:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:514:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:515:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:516:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:517:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:518:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:519:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:520:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:521:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:522:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:528:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:529:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:530:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:531:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:532:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:533:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:534:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:535:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:536:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:537:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:538:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:539:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:540:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:541:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:542:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:543:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:544:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:545:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:546:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:552:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:553:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:554:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:555:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:556:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:557:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:558:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:559:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:560:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:561:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:562:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:563:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:564:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:565:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:566:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:572:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:573:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:574:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:575:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:576:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:577:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:578:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:579:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:580:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:581:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:582:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:588:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:589:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:590:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:591:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:592:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:593:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:594:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:595:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:596:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:597:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:598:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:604:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:605:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:606:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:607:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:608:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:609:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:610:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:611:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:612:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:613:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:614:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:615:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:616:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:617:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:623:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:624:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:625:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:626:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:627:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:628:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:629:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:630:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:631:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:632:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:633:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:634:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:635:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:636:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:637:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:638:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:639:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:640:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:641:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:642:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:643:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:644:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:645:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:651:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:652:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:653:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:654:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:655:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:656:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:657:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:658:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:659:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:660:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:661:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:662:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:663:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:664:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:665:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:666:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:667:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:668:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:674:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:675:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:676:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:677:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:678:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:679:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:680:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:681:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:682:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:683:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:684:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:685:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:686:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:687:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:688:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:689:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:690:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:691:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:692:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:697:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:698:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:699:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:700:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:701:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:702:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:703:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:704:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:705:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:706:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:707:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:708:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:709:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:710:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:711:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:712:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:713:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:714:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:720:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:721:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:722:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:723:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:724:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:725:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:726:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:727:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:728:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:729:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:730:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:731:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:732:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:733:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:734:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:735:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:736:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:737:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:743:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:744:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:745:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:746:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:747:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:748:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:749:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:750:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:751:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:752:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:753:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:759:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:760:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:761:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:762:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:763:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:764:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:765:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:766:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:767:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:768:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:769:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:770:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:771:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:772:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:773:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:774:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:775:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:776:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:777:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:778:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:784:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:785:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:786:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:787:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:788:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:789:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:790:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:791:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:792:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:793:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:794:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:795:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:796:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:797:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:798:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:799:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:800:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:801:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:802:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:803:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:809:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:810:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:811:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:812:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:813:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:814:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:815:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:816:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:817:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:818:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:819:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:820:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:821:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:822:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:823:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:824:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:825:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:826:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:827:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:828:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:834:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:835:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:836:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:837:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:838:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:839:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:840:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:841:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:842:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:843:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:844:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:845:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:846:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:847:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:848:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:849:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:850:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:856:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:857:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:858:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:859:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:860:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:861:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:862:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:863:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:864:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:865:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:866:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:867:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:868:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:869:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:870:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:871:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:872:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:873:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:874:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:875:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:876:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:877:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:878:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:879:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:880:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:881:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:887:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:888:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:889:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:890:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:891:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:892:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:893:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:894:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:895:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:896:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:897:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:898:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:899:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:900:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:901:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:902:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:903:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:904:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:905:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:906:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:907:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:908:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:909:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:910:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:916:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:917:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:918:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:919:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:920:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:921:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:922:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:923:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:924:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:925:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_root_certs.h:926:  Lines should be <= 80 characters long…
Fix linter complaints in src/node_script.cc and src/node_script.h
src/node_script.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_script.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_script.cc:114:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
src/node_script.cc:120:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_script.cc:124:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
src/node_script.cc:125:  Extra space before )  [whitespace/parens] [2]
src/node_script.cc:126:  Extra space before )  [whitespace/parens] [2]
src/node_script.cc:325:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_script.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_SCRIPT_H_  [build/header_guard] [5]
src/node_script.h:36:  #endif line should be "#endif  // SRC_NODE_SCRIPT_H_"  [build/header_guard] [5]
src/node_script.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_script.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_script.h:27:  Include the directory when naming .h files  [build/include] [4]
src/node_script.h:28:  Include the directory when naming .h files  [build/include] [4]
src/node_script.h:35:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/node_script.h:36:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/node_signal_watcher.cc and src/node_sign…
…al_watcher.h

src/node_signal_watcher.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_signal_watcher.cc:27:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_signal_watcher.cc:40:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_signal_watcher.cc:94:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_signal_watcher.cc:96:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_signal_watcher.cc:109:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_signal_watcher.cc:112:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_signal_watcher.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_SIGNAL_WATCHER_H_  [build/header_guard] [5]
src/node_signal_watcher.h:61:  #endif line should be "#endif  // SRC_NODE_SIGNAL_WATCHER_H_"  [build/header_guard] [5]
src/node_signal_watcher.h:25:  Include the directory when naming .h files  [build/include] [4]
src/node_signal_watcher.h:26:  Include the directory when naming .h files  [build/include] [4]
src/node_signal_watcher.h:38:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/node_signal_watcher.h:44:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
Fix linter complaints in src/node_javascript.cc and src/node_javascri…
…pt.h

src/node_javascript.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_javascript.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_javascript.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/node_javascript.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/node_javascript.cc:26:  Found C system header after other header. Should be: node_javascript.h, c system, c++ system, other.  [build/include_order] [4]
src/node_javascript.cc:28:  Found C system header after other header. Should be: node_javascript.h, c system, c++ system, other.  [build/include_order] [4]
src/node_javascript.cc:31:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_javascript.cc:45:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_javascript.h:0:  No #ifndef header guard found, suggested CPP variable is: SRC_NODE_JAVASCRIPT_H_  [build/header_guard] [5]
src/node_javascript.h:22:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_stat_watcher.cc and src/node_stat_w…
…atcher.h

src/node_stat_watcher.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_stat_watcher.cc:30:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_stat_watcher.cc:47:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/node_stat_watcher.cc:97:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_stat_watcher.cc:123:  Extra space before ( in function call  [whitespace/parens] [4]
src/node_stat_watcher.cc:126:  Is this a non-const reference? If so, make const or use a pointer.  [runtime/references] [2]
src/node_stat_watcher.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_STAT_WATCHER_H_  [build/header_guard] [5]
src/node_stat_watcher.h:64:  #endif line should be "#endif  // SRC_NODE_STAT_WATCHER_H_"  [build/header_guard] [5]
src/node_stat_watcher.h:25:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_string.cc and src/node_string.h
src/node_string.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/node_string.cc:26:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_string.cc:38:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/node_string.h:25:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/node_version.h
src/node_version.h:26:  #ifndef header guard has wrong style, please use: SRC_NODE_VERSION_H_  [build/header_guard] [5]
src/node_version.h:57:  #endif line should be "#endif  // SRC_NODE_VERSION_H_"  [build/header_guard] [5]
src/node_version.h:23:  Include the directory when naming .h files  [build/include] [4]
src/node_version.h:55:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
Fix linter complaints in src/node_zlib.cc
src/node_zlib.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/node_zlib.cc:24:  Found C system header after other header. Should be: node_zlib.h, c system, c++ system, other.  [build/include_order] [4]
src/node_zlib.cc:25:  Found C system header after other header. Should be: node_zlib.h, c system, c++ system, other.  [build/include_order] [4]
src/node_zlib.cc:26:  Found C system header after other header. Should be: node_zlib.h, c system, c++ system, other.  [build/include_order] [4]
src/node_zlib.cc:27:  Found C system header after other header. Should be: node_zlib.h, c system, c++ system, other.  [build/include_order] [4]
src/node_zlib.cc:29:  Include the directory when naming .h files  [build/include] [4]
src/node_zlib.cc:30:  Include the directory when naming .h files  [build/include] [4]
src/node_zlib.cc:31:  Include the directory when naming .h files  [build/include] [4]
src/node_zlib.cc:35:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_zlib.cc:61:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/node_zlib.cc:162:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
src/node_zlib.cc:169:  Blank line at the start of a code block.  Is this needed?  [whitespace/blank_line] [2]
Fix linter complaints in src/pipe_wrap.cc and src/pipe_wrap.h
src/pipe_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/pipe_wrap.cc:52:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/pipe_wrap.cc:93:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/pipe_wrap.cc:127:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/pipe_wrap.cc:129:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/pipe_wrap.cc:174:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/pipe_wrap.cc:183:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/pipe_wrap.cc:188:  Using C-style cast.  Use reinterpret_cast<uv_pipe_t*>(...) instead  [readability/casting] [4]
src/pipe_wrap.cc:208:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/pipe_wrap.cc:218:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/pipe_wrap.cc:220:  Using C-style cast.  Use reinterpret_cast<ConnectWrap*>(...) instead  [readability/casting] [4]
src/pipe_wrap.cc:221:  Using C-style cast.  Use reinterpret_cast<PipeWrap*>(...) instead  [readability/casting] [4]
src/pipe_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_PIPE_WRAP_H_  [build/header_guard] [5]
src/pipe_wrap.h:59:  #endif line should be "#endif  // SRC_PIPE_WRAP_H_"  [build/header_guard] [5]
src/pipe_wrap.h:24:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/process_wrap.cc
src/process_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/process_wrap.cc:29:  Found C system header after other header. Should be: process_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/process_wrap.cc:30:  Found C system header after other header. Should be: process_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/process_wrap.cc:87:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/process_wrap.cc:182:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/process_wrap.cc:219:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/process_wrap.cc:239:  Should have a space between // and comment  [whitespace/comments] [4]
src/process_wrap.cc:241:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/process_wrap.cc:241:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/process_wrap.cc:242:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
Fix linter complaints in src/req_wrap.h
src/req_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_REQ_WRAP_H_  [build/header_guard] [5]
src/req_wrap.h:80:  #endif line should be "#endif  // SRC_REQ_WRAP_H_"  [build/header_guard] [5]
src/req_wrap.h:25:  Include the directory when naming .h files  [build/include] [4]
src/req_wrap.h:73:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/slab_allocator.cc and src/slab_allocator.h
src/slab_allocator.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/slab_allocator.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/slab_allocator.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/slab_allocator.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/slab_allocator.cc:26:  Found C system header after other header. Should be: slab_allocator.h, c system, c++ system, other.  [build/include_order] [4]
src/slab_allocator.cc:27:  Found C system header after other header. Should be: slab_allocator.h, c system, c++ system, other.  [build/include_order] [4]
src/slab_allocator.cc:28:  Found C system header after other header. Should be: slab_allocator.h, c system, c++ system, other.  [build/include_order] [4]
src/slab_allocator.cc:62:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/slab_allocator.cc:128:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/slab_allocator.h:0:  No #ifndef header guard found, suggested CPP variable is: SRC_SLAB_ALLOCATOR_H_  [build/header_guard] [5]
src/slab_allocator.h:22:  Include the directory when naming .h files  [build/include] [4]
src/slab_allocator.h:27:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/slab_allocator.h:28:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/slab_allocator.h:28:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/slab_allocator.h:39:  Labels should always be indented at least one space.  If this is a member-initializer list in a constructor or the base class list in a class definition, the colon should be on the following line.  [whitespace/labels] [4]
src/slab_allocator.h:49:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/stream_wrap.cc and src/stream_wrap.h
src/stream_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:28:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:29:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.cc:31:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/stream_wrap.cc:31:  Found C system header after other header. Should be: stream_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/stream_wrap.cc:32:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/stream_wrap.cc:32:  Found C system header after other header. Should be: stream_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/stream_wrap.cc:69:  More than one command on the same line  [whitespace/newline] [4]
src/stream_wrap.cc:69:  You don't need a ; after a }  [readability/braces] [4]
src/stream_wrap.cc:69:  Extra space before ( in function call  [whitespace/parens] [4]
src/stream_wrap.cc:70:  More than one command on the same line  [whitespace/newline] [4]
src/stream_wrap.cc:70:  You don't need a ; after a }  [readability/braces] [4]
src/stream_wrap.cc:84:  All parameters should be named in a function  [readability/function] [3]
src/stream_wrap.cc💯  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:110:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:127:  Using C-style cast.  Use reinterpret_cast<uv_pipe_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:231:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:254:  Extra space before ( in function call  [whitespace/parens] [4]
src/stream_wrap.cc:312:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/stream_wrap.cc:338:  Extra space before ( in function call  [whitespace/parens] [4]
src/stream_wrap.cc:355:  Using C-style cast.  Use reinterpret_cast<uint16_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:373:  Using C-style cast.  Use reinterpret_cast<uv_pipe_t*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:433:  Using C-style cast.  Use reinterpret_cast<WriteWrap*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:434:  Using C-style cast.  Use reinterpret_cast<StreamWrap*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:484:  Using C-style cast.  Use reinterpret_cast<StreamWrap*>(...) instead  [readability/casting] [4]
src/stream_wrap.cc:507:  Blank line at the end of a code block.  Is this needed?  [whitespace/blank_line] [3]
src/stream_wrap.cc:355:  Add #include <string> for string  [build/include_what_you_use] [4]
src/stream_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_STREAM_WRAP_H_  [build/header_guard] [5]
src/stream_wrap.h:86:  #endif line should be "#endif  // SRC_STREAM_WRAP_H_"  [build/header_guard] [5]
src/stream_wrap.h:25:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.h:26:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.h:27:  Include the directory when naming .h files  [build/include] [4]
src/stream_wrap.h:62:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Fix linter complaints in src/tcp_wrap.cc and src/tcp_wrap.h
src/tcp_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.cc:29:  Found C system header after other header. Should be: tcp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/tcp_wrap.cc:34:  Found C system header after other header. Should be: tcp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/tcp_wrap.cc:35:  Found C system header after other header. Should be: tcp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/tcp_wrap.cc:40:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/tcp_wrap.cc:41:  Found C system header after other header. Should be: tcp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/tcp_wrap.cc:104:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/tcp_wrap.cc:119:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/tcp_wrap.cc:158:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/tcp_wrap.cc:160:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/tcp_wrap.cc:303:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/tcp_wrap.cc:316:  Using C-style cast.  Use reinterpret_cast<uv_tcp_t*>(...) instead  [readability/casting] [4]
src/tcp_wrap.cc:333:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/tcp_wrap.cc:347:  Using C-style cast.  Use reinterpret_cast<ConnectWrap*>(...) instead  [readability/casting] [4]
src/tcp_wrap.cc:348:  Using C-style cast.  Use reinterpret_cast<TCPWrap*>(...) instead  [readability/casting] [4]
src/tcp_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_TCP_WRAP_H_  [build/header_guard] [5]
src/tcp_wrap.h:66:  #endif line should be "#endif  // SRC_TCP_WRAP_H_"  [build/header_guard] [5]
src/tcp_wrap.h:24:  Include the directory when naming .h files  [build/include] [4]
src/tcp_wrap.h:37:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/tcp_wrap.h:53:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
Fix linter complaints in src/timer_wrap.cc
src/timer_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/timer_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/timer_wrap.cc:81:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/timer_wrap.cc:82:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
Fix linter complaints in src/tty_wrap.cc and src/tty_wrap.h
src/tty_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.cc:64:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/tty_wrap.cc:178:  Using C-style cast.  Use reinterpret_cast<uv_stream_t*>(...) instead  [readability/casting] [4]
src/tty_wrap.h:22:  #ifndef header guard has wrong style, please use: SRC_TTY_WRAP_H_  [build/header_guard] [5]
src/tty_wrap.h:58:  #endif line should be "#endif  // SRC_TTY_WRAP_H_"  [build/header_guard] [5]
src/tty_wrap.h:25:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.h:26:  Include the directory when naming .h files  [build/include] [4]
src/tty_wrap.h:56:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/tty_wrap.h:58:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/udp_wrap.cc and src/udp_wrap.h
src/udp_wrap.cc:22:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:23:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:24:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.cc:29:  Found C system header after other header. Should be: udp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/udp_wrap.cc:37:  Found C system header after other header. Should be: udp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/udp_wrap.cc:38:  Found C system header after other header. Should be: udp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/udp_wrap.cc:43:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/udp_wrap.cc:44:  Found C system header after other header. Should be: udp_wrap.h, c system, c++ system, other.  [build/include_order] [4]
src/udp_wrap.cc:49:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/udp_wrap.cc:65:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/udp_wrap.cc:67:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/udp_wrap.cc:74:  All parameters should be named in a function  [readability/function] [3]
src/udp_wrap.cc:163:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/udp_wrap.cc:261:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/udp_wrap.cc:261:  If an else has a brace on one side, it should have it on both  [readability/braces] [5]
src/udp_wrap.cc:325:  Missing username in TODO; it should look like "// TODO(my_username): Stuff."  [readability/todo] [2]
src/udp_wrap.cc:403:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/udp_wrap.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
src/udp_wrap.h:1:  #ifndef header guard has wrong style, please use: SRC_UDP_WRAP_H_  [build/header_guard] [5]
src/udp_wrap.h:60:  #endif line should be "#endif  // SRC_UDP_WRAP_H_"  [build/header_guard] [5]
src/udp_wrap.h:4:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.h:5:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.h:6:  Include the directory when naming .h files  [build/include] [4]
src/udp_wrap.h:39:  Single-argument constructors should be marked explicit.  [runtime/explicit] [5]
src/udp_wrap.h:58:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/udp_wrap.h:60:  At least two spaces is best between code and comments  [whitespace/comments] [2]
Fix linter complaints in src/v8_typed_array.cc and src/v8_typed_array.h
src/v8_typed_array.cc:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
src/v8_typed_array.cc:25:  Include the directory when naming .h files  [build/include] [4]
src/v8_typed_array.cc:26:  Include the directory when naming .h files  [build/include] [4]
src/v8_typed_array.cc:27:  Include the directory when naming .h files  [build/include] [4]
src/v8_typed_array.cc:28:  Include the directory when naming .h files  [build/include] [4]
src/v8_typed_array.cc:242:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
src/v8_typed_array.cc:251:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/v8_typed_array.cc:280:  At least two spaces is best between code and comments  [whitespace/comments] [2]
src/v8_typed_array.cc:317:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:319:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:336:  Should have a space between // and comment  [whitespace/comments] [4]
src/v8_typed_array.cc:344:  Using C-style cast.  Use static_cast<char>(...) instead  [readability/casting] [4]
src/v8_typed_array.cc:349:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:351:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:352:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:354:  Using C-style cast.  Use static_cast<int>(...) instead  [readability/casting] [4]
src/v8_typed_array.cc:359:  Using C-style cast.  Use static_cast<float>(...) instead  [readability/casting] [4]
src/v8_typed_array.cc:361:  Using C-style cast.  Use static_cast<double>(...) instead  [readability/casting] [4]
src/v8_typed_array.cc:389:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/v8_typed_array.cc:505:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:510:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:551:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:556:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:765:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:769:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:797:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.cc:801:  Use int16/int64/etc, rather than the C type short  [runtime/int] [4]
src/v8_typed_array.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
src/v8_typed_array.h:22:  #ifndef header guard has wrong style, please use: SRC_V8_TYPED_ARRAY_H_  [build/header_guard] [5]
src/v8_typed_array.h:33:  #endif line should be "#endif  // SRC_V8_TYPED_ARRAY_H_"  [build/header_guard] [5]
src/v8_typed_array.h:25:  Include the directory when naming .h files  [build/include] [4]
Fix linter complaints in src/v8abbr.h
src/v8abbr.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
src/v8abbr.h:6:  #ifndef header guard has wrong style, please use: SRC_V8ABBR_H_  [build/header_guard] [5]
src/v8abbr.h:86:  #endif line should be "#endif  // SRC_V8ABBR_H_"  [build/header_guard] [5]
Add cpplint as a dependency of the node and node_g targets and vcbuil…
…d.bat

Also add '-' to the front of the cpplint command to ignore errors.
This is intended to be a temporary measure to prevent too much
disruption while everyone adjusts to the linter rules.  At some
point, the '-' should be removed so that linter failures will
cause the build to fail.
The same goes for vcbuild.bat.  At some point the @rem should
be removed from line 72 so that linter failures will cause the
build to fail on windows too.
Member

bnoordhuis commented Jun 10, 2012

I wish you would've discussed this first because it must have been a lot of work. Some nice things in there but a lot of it is noise and some of the changes are plain wrong.

I don't want to outright close this PR but I'm generally -1 on it. Other committers?

Things I like:

  • personalized TODO comments
  • explicit constructors (never been an issue but explicit > implicit)
  • proper using directives (never been an issue either but still nice for the same reason)

Things that are wrong:

  • the changes to node_script.cc
  • _snprintf() instead of snprintf(). There's a reason I added it in a4a04f9.
  • System includes, e.g. #include <v8.h> - I want the build to fail if the compiler can't find a header file, it should not pick up headers from the system-wide libv8 / libuv / zlib / etc. because they're likely the wrong ones.
  • this list may not be exhaustive :-)

Everything else - two spaces before a comment, C++-style casts, etc. - is irrelevant noise, as far as I'm concerned.

EDIT: Sorry if that comes across as harsh, that's not the intent, but I don't want to sugarcoat it either.

Would you have preferred to add arguments to the cpplint.py command-line to globally disable categories for the things you don't like (like 2 spaces before comments?)

Aside from being hideously ugly (no argument from me there!), what's wrong about the changes in node_script.cc? Would it be better to just exclude that file from being linted altogether?

The includes for vendored headers (v8.h, uv.h, etc) can be reverted back and tagged with a NOLINT comment.

No hard feelings here. It was a lot of work, but I think it was worth it and is still valuable. Let's work together to get something you can be +1 on :)

@bnoordhuis, regarding #include "v8.h" vs. #include <v8.h>:

When cpplint complained about this, I was thrown off by it at first too. I had always believed that angle brackets (<>) were exclusively for standard headers (stdio.h, for example) and that quotes were for everything else. I was just going to use ../ to get the right path, but thought that seemed a little brittle. So I went to see what Google's style guide (which cpplint attempts to enforce) recommended. Unfortunately, it said:

All of a project's header files should be listed as descendants of the project's source directory without use of UNIX directory shortcuts . (the current directory) or .. (the parent directory)

That led me to dig into the docs for the preprocessor to find a solution (which turned out to be using angle brackets).

If I understand the docs for gcc and [VC++](http://msdn.microsoft.com/en-us/library/36k2cdd4(v=vs.100\).aspx) correctly, using quotes instead of angle brackets won't give the behavior you described (preventing the system-wide directories from being searched). According to them, in the case of a header that is missing from the including file's directory (src/) and the appropriate deps/ directory (which I believe GYP adds with /I) the system directories are going to be searched no matter which form is used.

In other words, if the system-wide headers exist they will be used, but only if src/ (in the case of quotes) and deps/<lib>/... (in both cases) don't contain the requested header. Using quotes or angle brackets doesn't seem to change that.

Again, no hard feelings here, and I'm certainly not trying to disparage you any way. I just wanted to share something I discovered in the process of creating this PR. Feedback is always very welcome :)

isaacs commented Jun 10, 2012

In theory I'm +1 on this. Though I do echo @bnoordhuis's sentiments to discuss before undertaking such a thing, it's mostly valuable.

The "noise" things are stuff that we should either disable in the linter, or just bite the bullet all at once (as this commit mostly does.) Working with linted code is somewhat nicer in general, and in the long run is a good thing, even for the bs style stuff. We did this in the JS, and it's been a nice addition to help maintain consistency. (Merges from v0.6 are a bit more painful, but they're slowing down anyway.)

I've never actually understood what the difference is between "" and <> for include statements. What's the actual difference in behavior? Is there some specific case that we support now which we wouldn't otherwise?

We should absolutely not have // NOLINT comments littered throughout the code. Either refactor so that it passes, or turn off that lint feature globally.

#include

@isaacs, after reading this and [this](http://msdn.microsoft.com/en-us/library/36k2cdd4(v=vs.100\).aspx) my understanding now is that the only difference between "" and <> is that "" will first look for the header in the including file's directory, then the directories of any files that #include the including file (and so on), and if still not found, will behave the same as <> (which is to search -I paths, followed by system-default include paths).

// NOLINT

I agree 100% that // NOLINT comments should be avoided whenever possible, and looking back at the changes there are a few places where I was probably a little too conservative in not wanting to impact the existing code. I'll go back and refactor a little more aggressively so the comments can be removed from those spots. However, sometimes refactoring could hurt readability or break functionality and globally disabling the warning might be too blunt of an approach in certain circumstances. For example:

node_crypto.cc:339: unsigned long err; The linter wants us to use uint64_t instead of unsigned long, but err is assigned the result of ERR_peek_last_error() (which is defined as unsigned long by openssl).

IMO, this linter warning is a valuable one (particularly when dealing with serialization of data) that I wouldn't want to disable globally, but since we can't control the return type and long varies in size based on platform/architecture, it seems our choices are use the preprocessor to control whether it's uint32_t or uint64_t, or use a // NOLINT comment. With the goal of trying to impact the code as little as possible, the comment seemed like the better approach. Do you agree, or would you have taken another approach?

I'm committed to getting this into a state that everyone can be happy with and I think a PR is a great way to have a concrete discussion about the details. Opinions tend to vary widely on this sort of thing, so I just took a shot at it with the expectation that it would be refined in the PR.

Please, keep the feedback coming :)

Member

bnoordhuis commented Jun 11, 2012

I misremembered what the deal with #include <v8.h> was (but I remember it now :-).

We used to add -I/usr/local/include to the search path on FreeBSD but that caused all kinds of weird errors for some people because the compiler picked up headers from the libv8 (or node or zlib or ...) from ports, not the ones we bundle. Which reminds me that we need to start using -iquote again...

Anyway, if nothing else, #include "v8.h" signals intent: we want to include a project header, not a system header.

Member

bnoordhuis commented Jun 11, 2012

node_crypto.cc:339: unsigned long err; The linter wants us to use uint64_t instead of unsigned long, but err is assigned the result of ERR_peek_last_error() (which is defined as unsigned long by openssl).

The linter is wrong, it simply should not complain about that.

@bnoordhuis, I just attempted to rework the node_script.cc changes to avoid the linter problems. Could you have a look at the diff? Does that code sit any better with you?

I also attempted to avoid using // NOLINT in io_watcher, signal_watcher, and stat_watcher, but I'm not all that comfortable with libev, so if you or someone else could have a look at those for correctness I would appreciate it. FWIW, make test output still matches the output of the unmodified code.

Node does not use anything from the STL. What cpplint complains about is how the multi-line string literal is defined, it expects "foo" "bar", not the trailing backslash style.

Member

bnoordhuis commented Jun 11, 2012

I also attempted to avoid using // NOLINT in io_watcher, signal_watcher, and stat_watcher

Don't bother with those files, they'll be removed soon.

@bnoordhuis, I think I got it this time ;-)

Thanks for the "foo" "bar" tip, I didn't even realize the compiler would allow that. I'd always used the trailing backslash in the past.

I can work on reverting the #includes and disabling Include the directory when naming .h files in the linter. What else can I tweak to get your +1?

isaacs commented Jun 11, 2012

Let's get this into the v0.9 timeline. We're too close to releasing v0.8 to make changes like this, and it meshes nicely with the "clean up" mission of v0.9.

That means this definitely won't be merged in for the next few weeks, and I need @bnoordhuis to help getting v0.8 over the finish line. Please understand a slight delay :)

No problem! I'm as excited for v0.8 as everyone else is :) In the meantime, I'll try to keep pace with master and address any linter issues that come up.

Matt Gollob added some commits Jun 20, 2012

Merge remote-tracking branch 'upstream/master'
Conflicts:
	src/node.cc
	src/node_crypto.cc
	src/node_version.h
Fix linter complaints in src/node_win32_etw_provider.cc, src/node_win…
…32_etw_provider-inl.h, and src/node_win32_etw_provider.h

src/node_win32_etw_provider.cc:28:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_win32_etw_provider.cc:67:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
src/node_win32_etw_provider.cc:91:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
src/node_win32_etw_provider-inl.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_WIN32_ETW_PROVIDER_INL_H_  [build/header_guard] [5]
src/node_win32_etw_provider-inl.h:145:  #endif line should be "#endif  // SRC_NODE_WIN32_ETW_PROVIDER_INL_H_"  [build/header_guard] [5]
src/node_win32_etw_provider-inl.h:30:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_win32_etw_provider-inl.h:40:  Using sizeof(type).  Use sizeof(varname) instead if possible  [runtime/sizeof] [1]
src/node_win32_etw_provider-inl.h:67:  Missing space after ,  [whitespace/comma] [3]
src/node_win32_etw_provider-inl.h:145:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
src/node_win32_etw_provider.h:22:  #ifndef header guard has wrong style, please use: SRC_NODE_WIN32_ETW_PROVIDER_H_  [build/header_guard] [5]
src/node_win32_etw_provider.h:82:  #endif line should be "#endif  // SRC_NODE_WIN32_ETW_PROVIDER_H_"  [build/header_guard] [5]
src/node_win32_etw_provider.h:30:  Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]
src/node_win32_etw_provider.h:82:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Fix linter complaints in src/eio-emul.h
src/eio-emul.h:23:  #ifndef header guard has wrong style, please use: SRC_EIO_EMUL_H_  [build/header_guard] [5]
src/eio-emul.h:71:  #endif line should be "#endif  // SRC_EIO_EMUL_H_"  [build/header_guard] [5]
src/eio-emul.h:26:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:26:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:27:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:27:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:28:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:28:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:29:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:29:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:30:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:30:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:31:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:31:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:32:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:32:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:33:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:33:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:34:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:34:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:35:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:35:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:36:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:36:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:37:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:37:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:38:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:38:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:39:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:39:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:40:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:40:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:41:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:41:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:42:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:42:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:43:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:43:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:44:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:44:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:45:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:45:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:46:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:46:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:47:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:47:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:48:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:48:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:49:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:49:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:50:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:50:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:51:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:51:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:52:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:52:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:53:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:53:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:54:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:54:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:55:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:55:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:56:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:56:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:57:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:57:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:58:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:58:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:59:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:59:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:60:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:60:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:61:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:61:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:62:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:62:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:63:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:63:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:64:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:64:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:65:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:65:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:66:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:66:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:67:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:67:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:68:  Lines should very rarely be longer than 100 characters  [whitespace/line_length] [4]
src/eio-emul.h:68:  Missing space after ,  [whitespace/comma] [3]
src/eio-emul.h:68:  All parameters should be named in a function  [readability/function] [3]
src/eio-emul.h:69:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
src/eio-emul.h:69:  Missing space after ,  [whitespace/comma] [3]
Fix linter complaints in src/ev-emul.h
src/ev-emul.h:23:  #ifndef header guard has wrong style, please use: SRC_EV_EMUL_H_  [build/header_guard] [5]
src/ev-emul.h:259:  #endif line should be "#endif  // SRC_EV_EMUL_H_"  [build/header_guard] [5]
src/ev-emul.h:81:  Using C-style cast.  Use reinterpret_cast<uv_handle_t*>(...) instead  [readability/casting] [4]
src/ev-emul.h:87:  Using C-style cast.  Use reinterpret_cast<type*>(...) instead  [readability/casting] [4]
Fix linter complaints in src/node_crypto.cc and src/node_crypto.h
src/node_crypto.cc:2117:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
src/node_crypto.cc:2545:  { should almost always be at the end of the previous line  [whitespace/braces] [4]
Merge remote-tracking branch 'upstream/master' into integ
Conflicts:
	src/node.h
	src/node_file.cc
Ignore runtime/int linter errors in node_crypto.cc
Most of them are regarding types that are set in signatures defined
by OpenSSL.

@isaacs, to prevent unnecessary pain to @mattness, if he updates the pull request to be merge-able with master would you take it?

@mattness, if that's the case think you could get this updated? (I know how much everyone loves to fix syntax ;-)

@trevnorris, I appreciate you trying to save me pain but IMHO just being merge-able with master isn't good enough. A change like this is far more valuable when it's complete. If the core team is willing to merge it, I'll make sure it's complete and done to their satisfaction.

Life has gotten in the way of me keeping up with master, but I will find the time if there's interest in this PR.

Can one of the admins verify this patch?

@mattness I'm going to close this for now. If you plan on re-doing this on the same PR just comment and I'll reopen.

@trevnorris trevnorris closed this May 21, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.