Drop vestigial `process.installPrefix`, `node --vars`, NODE_CFLAGS and NODE_PREFIX #3483

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

trentm commented Jun 18, 2012

Also removed unused node_config.h.in (replaced with config.gypi a while
back).

If/when this is pulled in, I can update https://github.com/joyent/node/wiki/API-changes-between-v0.6-and-v0.8 to mention the dropped process.installPrefix.

Notes:

  • process.installPrefix and node --vars worked in node 0.4.x.
  • Not so in node 0.6.x (process.installPrefix is always undefined and node --vars prints nothing and exits 0.
  • Given this behaviour in 0.6 I'm presuming it is okay to just yank them from the 0.8 release, rather than having some longer term official deprecation.
@trentm trentm Drop vestigial `process.installPrefix`, `node --vars`, NODE_CFLAGS an…
…d NODE_PREFIX

Also removed unused node_config.h.in (replaced with config.gypi a while
back).
452a56c
Owner

bnoordhuis commented Jun 18, 2012

LGTM. Other committers?

Owner

indutny commented Jun 18, 2012

LGTM

Owner

bnoordhuis commented Jun 18, 2012

Thanks Trent, landed in 196207c.

bnoordhuis closed this Jun 18, 2012

trentm commented Jun 18, 2012

Thanks!

@iarna iarna added a commit to npm/npm that referenced this pull request Jan 6, 2016

@jeffmcmahan @iarna jeffmcmahan + iarna doc: process.installPrefix was removed as of 0.8.x.
process.installPrefix was removed here:
nodejs/node-v0.x-archive#3483.  It was
announced here:
https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8.

PR-URL: #10990
Credit: @jeffmcmahan
80412d4

@iarna iarna added a commit to npm/npm that referenced this pull request Jan 7, 2016

@jeffmcmahan @iarna jeffmcmahan + iarna doc: drop mention of `process.installPrefix`
process.installPrefix was removed here:
nodejs/node-v0.x-archive#3483.  It was
announced here:
https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8.

PR-URL: #10990
Credit: @jeffmcmahan
c6ce69e

marekventur referenced this pull request in marekventur/dependency-updater Jan 9, 2016

Closed

Update "npm" to version 3.5.4 #11

@zkat zkat added a commit to npm/npm that referenced this pull request Jan 19, 2016

@jeffmcmahan @zkat jeffmcmahan + zkat doc: process.installPrefix was removed as of 0.8.x
process.installPrefix was removed here:
nodejs/node-v0.x-archive#3483.

It was announced here:
https://github.com/jhnns/node/wiki/API-changes-between-v0.6-and-v0.8.

PR-URL: #10990
Credit: @jeffmcmahan
8288365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment