repl: Don't search for `npm` in `cmd` if `cmd` isn't a string. #3517

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Fixes #3515

Owner

bnoordhuis commented Jun 23, 2012

Colton, the test also passes without the patch.

@bnoordhuis Test fixed.

Owner

bnoordhuis commented Jun 28, 2012

Nice, test passes. I noticed one issue though: it stuffs "undefined\n" into self.bufferedCommand now. Not directly fatal but can you fix that while you're at it?

(And use the common commit log template, please.)

@bnoordhuis Uhm. What? I didn't see it throw in undefined when I ran the test?

Plus, line 306 should always empty out the self.bufferedCommand since there is no error being thrown.

Owner

bnoordhuis commented Jul 1, 2012

Uhm. What? I didn't see it throw in undefined when I ran the test?

I'm being proactive here. It's not a bug now but it might become one someday.

Southern commented Jul 1, 2012

@bnoordhuis Yeah, but as I said.. self.bufferedCommand on line 306 should always empty it out if there isn't an error in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment