punycode: Update to v1.1.1 #3561

Closed
wants to merge 2 commits into
from

2 participants

@mathiasbynens

The only change is that this version supports orphaned surrogates in ucs2encode and ucs2decode. For example, require('punycode').ucs2.encode([0xD800]) now returns '\uD800' rather than throwing an error.

@bnoordhuis
Node.js Foundation member

Mathias, can you add a regression test for that? Otherwise LGTM.

@mathiasbynens

Sure, but where/how? Any pointers? (There are tests for this in punycode.js repo, FWIW.)

@bnoordhuis
Node.js Foundation member

There are tests in test/simple/test-punycode.js. One or two new asserts should be sufficient.

@bnoordhuis
Node.js Foundation member

Thanks Mathias, landed in 2ba9645.

By the way, if you're ever in Amsterdam, come by the office and you can buy me a beer.

(Okay, okay - I'll buy the first round.)

@bnoordhuis bnoordhuis closed this Jul 4, 2012
@mathiasbynens

I’ll hold you to that promise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment