Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make crypto accept and emit buffers #3571

wants to merge 1 commit into


None yet
4 participants

Pull request rebased to current master. Only minor modifications were needed.

Fixes #1393

jcayzac commented Jul 1, 2012

I find 'binary' and null quite redundant and confusing. Shouldn't it just return a buffer if encoding is set to 'binary' ?

I agree (I would even say that binary encoding should be ditched altogether in favor of buffers), but there is an issue with backwards compatibility.

You can now use pseudo 'buffer' encoding in crypto

@bnoordhuis Close?


indutny commented Oct 1, 2012

I'll close it, it's irrelevant now.

@indutny indutny closed this Oct 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment