This repository has been archived by the owner. It is now read-only.

Fixed a bug with last command repeating in debugger #3921

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

rlidwka commented Aug 25, 2012

Debugger usually repeat it's last command if user submits an empty line. Unfortunately, this functionality depends on a bug that got fixed in 9126dd2 .

PS: Repl has history only if output is a terminal. So I see no way to test it using automated scripts.

Member

indutny commented Aug 27, 2012

Lgtm, have you signed CLA: http://nodejs.org/cla.html ?

Member

bnoordhuis commented Aug 27, 2012

Alex has signed the CLA. Is it possible to add a regression test for this?

Member

indutny commented Aug 27, 2012

Yeah, I think it is.

You can pass terminal: true as an option when creating the server to force it into "terminal mode". That should make writing a test case possible.

@ghost ghost assigned indutny Sep 28, 2012

Member

indutny commented Sep 28, 2012

Landed in 8ac1a73 and d68c02e

Member

indutny commented Sep 28, 2012

@isaacs should I backport this to v0.8?

rlidwka commented Oct 3, 2012

works just fine on master, thanks, closing

@rlidwka rlidwka closed this Oct 3, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.