This repository has been archived by the owner. It is now read-only.

Support building node with xcode #4022

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@tjfontaine

This adds an option to configure to generate xcode project files, fixes v8 dependency chain, and lets xcode pick the proper compiler version instead of trying to force GCC 4.2 which is not a supported compiler in OS X 10.8.

Fixes #4020

@@ -468,6 +473,7 @@ write('config.gypi', "# Do not edit. Generated by the configure script.\n" +
config = {
'BUILDTYPE': 'Debug' if options.debug else 'Release',
'USE_NINJA': str(int(options.use_ninja or 0)),
+ 'USE_XCODE': str(int(options.use_xcode or 0)),

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Sep 14, 2012

This doesn't look like it's necessary if the Makefile doesn't use the variable ever.

@TooTallNate

TooTallNate Sep 14, 2012

This doesn't look like it's necessary if the Makefile doesn't use the variable ever.

This comment has been minimized.

Show comment Hide comment
@tjfontaine

tjfontaine Sep 14, 2012

I left it incase someone else wanted to carry the torch later

@tjfontaine

tjfontaine Sep 14, 2012

I left it incase someone else wanted to carry the torch later

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Sep 29, 2012

does this belong upstream?

does this belong upstream?

This comment has been minimized.

Show comment Hide comment
@tjfontaine

tjfontaine Sep 29, 2012

Owner

I'm not sure, as things seem to build fine for other renderers like ninja and make so it could be a gyp xcode bug

Owner

tjfontaine replied Sep 29, 2012

I'm not sure, as things seem to build fine for other renderers like ninja and make so it could be a gyp xcode bug

@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Nov 5, 2012

Member

Thanks TJ, landed in d264b23, ac04716 and 0f3ddad.

Member

bnoordhuis commented Nov 5, 2012

Thanks TJ, landed in d264b23, ac04716 and 0f3ddad.

@bnoordhuis bnoordhuis closed this Nov 5, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.