This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Support building node with xcode #4022
Conversation
tjfontaine
added some commits
Sep 14, 2012
tjfontaine
referenced this pull request
Sep 14, 2012
Closed
support building via xcode for mac #4020
TooTallNate
reviewed
Sep 14, 2012
| @@ -468,6 +473,7 @@ write('config.gypi', "# Do not edit. Generated by the configure script.\n" + | ||
| config = { | ||
| 'BUILDTYPE': 'Debug' if options.debug else 'Release', | ||
| 'USE_NINJA': str(int(options.use_ninja or 0)), | ||
| + 'USE_XCODE': str(int(options.use_xcode or 0)), |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
TooTallNate
Sep 14, 2012
This doesn't look like it's necessary if the Makefile doesn't use the variable ever.
TooTallNate
Sep 14, 2012
This doesn't look like it's necessary if the Makefile doesn't use the variable ever.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
TooTallNate
commented on 61578c6
Sep 29, 2012
|
does this belong upstream? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
tjfontaine
Sep 29, 2012
Owner
I'm not sure, as things seem to build fine for other renderers like ninja and make so it could be a gyp xcode bug
|
I'm not sure, as things seem to build fine for other renderers like ninja and make so it could be a gyp xcode bug |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
bnoordhuis
closed this
Nov 5, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tjfontaine commentedSep 14, 2012
This adds an option to
configureto generate xcode project files, fixes v8 dependency chain, and lets xcode pick the proper compiler version instead of trying to force GCC 4.2 which is not a supported compiler in OS X 10.8.Fixes #4020