Report invalid stream given to chid_process.spawn stdio option #4032

Closed
wants to merge 3 commits into
from

3 participants

@langpavel

This should make error message in #4030 less confusing

@bnoordhuis bnoordhuis commented on an outdated diff Sep 19, 2012
lib/child_process.js
@@ -775,6 +775,9 @@ ChildProcess.prototype.spawn = function(options) {
} else {
// Cleanup
cleanup();
+ if(stdio && stdio.fd === null) {
@bnoordhuis
Node.js Foundation member
bnoordhuis added a line comment Sep 19, 2012

Style. I'd much rather fix it though. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@langpavel

@bnoordhuis What you suggest?
Should I try implement delayed spawn after stream open?

@Nodejs-Jenkins

Can one of the admins verify this patch?

@tjfontaine

Thanks but this was handled in a slightly different way, but it should be reporting it now.

@tjfontaine tjfontaine closed this Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment