DNS NAPTR, targets #3177 #4033

Closed
wants to merge 3 commits into
from

Projects

None yet

4 participants

@langpavel

Test not working, probably sip.voice.google.com has no NAPTR record?

Can anybody take valid NAPTR query into test?

targets #3177, #3170

@johntdyer, @ssuda can test this?

@saghul
Member
saghul commented Oct 24, 2012

You can use the sip2sip.info domain.

 dig -t naptr sip2sip.info

; <<>> DiG 9.6-ESV-R4-P3 <<>> -t naptr sip2sip.info
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 43840
;; flags: qr rd ra; QUERY: 1, ANSWER: 3, AUTHORITY: 3, ADDITIONAL: 2

;; QUESTION SECTION:
;sip2sip.info.                  IN      NAPTR

;; ANSWER SECTION:
sip2sip.info.           3600    IN      NAPTR   30 100 "s" "SIP+D2U" "" _sip._udp.sip2sip.info.
sip2sip.info.           3600    IN      NAPTR   10 100 "s" "SIP+D2T" "" _sip._tcp.sip2sip.info.
sip2sip.info.           3600    IN      NAPTR   20 100 "s" "SIPS+D2T" "" _sips._tcp.sip2sip.info.

;; AUTHORITY SECTION:
sip2sip.info.           9828    IN      NS      ns7.dns-hosting.info.
sip2sip.info.           9828    IN      NS      ns1.dns-hosting.info.
sip2sip.info.           9828    IN      NS      ns2.dns-hosting.info.

;; ADDITIONAL SECTION:
ns1.dns-hosting.info.   251     IN      A       81.23.228.131
_sip._udp.sip2sip.info. 1974    IN      SRV     100 100 5060 proxy.sipthor.net.

;; Query time: 44 msec
;; SERVER: 192.168.99.101#53(192.168.99.101)
;; WHEN: Wed Oct 24 23:40:42 2012
;; MSG SIZE  rcvd: 304
@langpavel

Working, still can be merged without conflicts.
Can someone review? @bnoordhuis @isaacs?

@isaacs
Collaborator
isaacs commented Mar 6, 2013

This looks good to me. (Should be squashed into one commit, but I can do that easily enough.)

I'd like to get #4933 in first, though.

@indutny
Member
indutny commented Mar 6, 2013

LGTM, squashed and landed as 2ad9872 (with some small style fixes).

@indutny indutny closed this Mar 6, 2013
@isaacs isaacs referenced this pull request Mar 6, 2013
Closed

DNS: Support NAPTR queries #3170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment