Clarify comment about URI auth in mailto host #4249

Closed
wants to merge 1 commit into
from

3 participants

@davidmurdoch

The previous comment was difficult to understand upon first read and had a few typos.

@davidmurdoch davidmurdoch Clarify comment about URI auth in mailto host
The previous comment was difficult to understand upon first read and had a few typos.
61312e9
@Nodejs-Jenkins

Can one of the admins verify this patch?

@jasnell jasnell added the P-3 label Jun 1, 2015
@jasnell jasnell added the doc label Aug 6, 2015
@jasnell
Node.js Foundation member

Given that (a) this is targeted at master, (b) it's out of date and (c) code comments update are a low priority, I'm going to go ahead and close this. It's not critical to land in v0.12 or v0.10. If this is still something that should land, the right thing would be to open a PR against nodejs/node.

@jasnell jasnell closed this Aug 13, 2015
@davidmurdoch davidmurdoch referenced this pull request in nodejs/node Aug 13, 2015
@rvagg rvagg Revert "url: significantly improve the performance of the url module"
This reverts commit 3fd7fc4.

It was agreed that this change contained too much potential ecosystem
breakage, particularly around the inability to `delete` properties off a
`Url` object. It may be re-introduced for a later release, along with
better work on ecosystem compatibility.

PR-URL: #1602
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Forrest L Norvell <forrest@npmjs.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Isaac Z. Schlueter <i@izs.me>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
702997c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment