This repository has been archived by the owner. It is now read-only.

Fix hardfloat detection #4250

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants

jadonk commented Nov 7, 2012

gcc has a builtin define to denote hard abi when in use, e.g. when
using -mfloat-abi=hard it will define __ARM_PCS_VFP to 1 and therefore
we should check that to determine which calling convention is in use
and not __VFP_FP__ which merely indicates presence of VFP unit

The fix has been provided by Khem Raj raj.khem@gmail.com

Updated to v0.8 branch and resubmitted by Jason Kridner jdk@ti.com

Upstream-Status: Forwarded

kraj and others added some commits Nov 7, 2012

Fix hardfloat detection
gcc has a builtin define to denote hard abi when in use, e.g. when
using -mfloat-abi=hard it will define __ARM_PCS_VFP to 1 and therefore
we should check that to determine which calling convention is in use
and not __VFP_FP__ which merely indicates presence of VFP unit

The fix has been provided by Khem Raj <raj.khem@gmail.com>

Updated to v0.8 branch and resubmitted by Jason Kridner <jdk@ti.com>

Upstream-Status: Forwarded
Resolve bad rpath issue when linking
See http://piscisaureus.no.de/libuv/2012-10-09#16:42:44.577 to
understand the issue.

Added to OE by Jason Kridner <jdk@ti.com>
Member

bnoordhuis commented Nov 8, 2012

The PR contains seemingly unrelated commits. It's about 0ffc68a, right? That issue has been fixed in node.js master.

As a rule, we don't take out of tree patches. To further complicate matters, I can't take a patch without a signed CLA from the original author.

Can one of the admins verify this patch?

jadonk commented Mar 14, 2013

Fixed in master.

@jadonk jadonk closed this Mar 14, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.