Add patch for stack overflow messages #4252

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

dizzyd commented Nov 8, 2012

This patch for V8 originates from: http://codereview.chromium.org/11275186/

The original patch from that URL does not apply cleanly to the v0.8 version of V8, so I've resolved the conflicts by hand.

Member

piscisaureus commented Nov 8, 2012

Is it possible to upload this to chromium backported patch to chromium code review and ask the v8 guys to land it in v8 v3.11.10 ?

dizzyd commented Nov 8, 2012

I have a dialog going with one of the V8 engineers -- I'll see what he thinks about backporting it to that version.

dizzyd commented Nov 10, 2012

Nope -- the V8 team will not backport this as it's a new feature and they don't receive real-world crash data anymore for 3.11.x (because of it's age). This patch will land in 3.15, but not sure how prepared node is to make that leap. :)

isaacs commented Mar 10, 2013

We have this in 0.10 already. Thanks!

isaacs closed this Mar 10, 2013

@smanders smanders pushed a commit to smanders/node-v0.x-archive that referenced this pull request Dec 17, 2015

@cjihrig cjihrig 2015-12-16, Version 5.3.0 (Stable)
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: nodejs/node#4281

Conflicts:
	src/node_version.h
e5774c9

@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Jan 13, 2016

@cjihrig cjihrig 2015-12-16, Version 5.3.0 (Stable)
Notable changes:

* buffer:
  - Buffer.prototype.includes() has been added to keep parity
    with TypedArrays. (Alexander Martin) #3567.
* domains:
  - Fix handling of uncaught exceptions.
    (Julien Gilli) #3654.
* https:
  - Added support for disabling session caching.
    (Fedor Indutny) #4252.
* repl:
  - Allow third party modules to be imported using
    require(). This corrects a regression from 5.2.0.
    (Ben Noordhuis) #4215.
* deps:
  - Upgrade libuv to 1.8.0.
    (Saúl Ibarra Corretgé) #4276.

PR-URL: nodejs/node#4281
b21110f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment