Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Do not cache stdout or stderr when there is no callback #4267

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

renorzr commented Nov 10, 2012

Sometimes we need to stream output of exec, there could be large amount of data. We use "event" instead of "callback" on this situation, but still limited by cache of stdout.

Owner

bnoordhuis commented Nov 10, 2012

Can you explain the purpose of this PR to me? The callback is not optional according to the documentation and though we don't enforce that right now, that's how you should treat it. Not passing in a callback is a bug in your application.

Is the idea to create a version of child_process.spawn() that runs your command in a shell?

Can one of the admins verify this patch?

renorzr commented Mar 15, 2013

@bnoordhuis is right, this is not needed since there is already child_process.spawn. closed.

@renorzr renorzr closed this Mar 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment