Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Do not cache stdout or stderr when there is no callback #4267

Closed
wants to merge 1 commit into from
Closed

Do not cache stdout or stderr when there is no callback #4267

wants to merge 1 commit into from

Conversation

renorzr
Copy link

@renorzr renorzr commented Nov 10, 2012

Sometimes we need to stream output of exec, there could be large amount of data. We use "event" instead of "callback" on this situation, but still limited by cache of stdout.

@bnoordhuis
Copy link
Member

Can you explain the purpose of this PR to me? The callback is not optional according to the documentation and though we don't enforce that right now, that's how you should treat it. Not passing in a callback is a bug in your application.

Is the idea to create a version of child_process.spawn() that runs your command in a shell?

@Nodejs-Jenkins
Copy link

Can one of the admins verify this patch?

@renorzr
Copy link
Author

renorzr commented Mar 15, 2013

@bnoordhuis is right, this is not needed since there is already child_process.spawn. closed.

@renorzr renorzr closed this Mar 15, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants