This repository has been archived by the owner. It is now read-only.

tls: do graceful shutdown #4347

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

indutny commented Dec 2, 2012

It's not really graceful, because server doesn't waits for client to reply, but at least it definitely sends close notify to client.

Member

bnoordhuis commented Dec 3, 2012

I'm aware mod_ssl does that but I've never been able to figure out why calling SSL_shutdown() multiple times would help. I always assumed it was a workaround for old, broken versions of OpenSSL. Any ideas?

Owner

indutny commented Dec 10, 2012

@bnoordhuis correct, check s3_lib.c source code - it's total bullshit. So now it's doing something more proper.

@indutny indutny commented on an outdated diff Dec 10, 2012

lib/tls.js
@@ -577,7 +595,7 @@ CryptoStream.prototype._pull = function() {
return;
}
- if (tmp.length == 0) continue;
+ if (!tmp || tmp.length == 0) continue;
@indutny

indutny Dec 10, 2012

Owner

This is probably unnecessary.

Owner

indutny commented Dec 21, 2012

Member

bnoordhuis commented Dec 28, 2012

What was the magic ab invocation again? I keep forgetting.

Owner

indutny commented Dec 29, 2012

ab -v 3

Owner

indutny commented Jan 16, 2013

@bnoordhuis any news?

Member

bnoordhuis commented Jan 16, 2013

any news?

Nasdaq is up .07%, Dow Jones is down .27%.

Regarding the patch, I'm not sure how it makes a difference. node.js / openssl already sends the close notify:

$ ab -v 3 -c 1 -n 1 https://127.0.0.1:8000/
<snip>
SSL/TLS Alert [read] warning:close notify
SSL/TLS Alert [write] warning:close notify
<snip>
Owner

indutny commented Mar 2, 2013

Not relevant.

@indutny indutny closed this Mar 2, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.