This repository has been archived by the owner. It is now read-only.

fix doc process.title for OS specific #4433

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@qxfusion

Fix issue with:

  • note prctl support change process name only in Linux 2.6.9+
  • note prctl support change process name only up to 16 bytes length
  • Windows and Linux specific note(s)
fix doc process.title for OS specific
Fix issue with:
- note prctl support change process name only in Linux 2.6.9+
- note prctl support change process name only up to 16 bytes length
- windows specific note(s)
@@ -383,6 +383,13 @@ The PID of the process.
Getter/setter to set what is displayed in 'ps'.
+Note: For Windows platform change ONLY console windows title, because OS specification don't provide method change "process name" on-the-fly.

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Dec 28, 2012

Member

Long lines, wrap at 80 columns.

@bnoordhuis

bnoordhuis Dec 28, 2012

Member

Long lines, wrap at 80 columns.

This comment has been minimized.

Show comment Hide comment
@qxfusion

qxfusion Dec 28, 2012

Sorry, don't know - not use terminal with 80 char line width :)

@qxfusion

qxfusion Dec 28, 2012

Sorry, don't know - not use terminal with 80 char line width :)

+Note: For Windows platform change ONLY console windows title, because OS specification don't provide method change "process name" on-the-fly.
+Note: For Windows Interix Service (UNIX simulation in Windows) 'ps' don't work properly.
+Note: For Linux change "process name" avaible only since Linux Kernel 2.6.9 or greater, otherwise function don't have effect.
+Note: For Linux "process name" string can't be length more 16 bytes.

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Dec 28, 2012

Member

Needs more detail. Only prctl(PR_SET_NAME) is limited to 16 bytes.

@bnoordhuis

bnoordhuis Dec 28, 2012

Member

Needs more detail. Only prctl(PR_SET_NAME) is limited to 16 bytes.

This comment has been minimized.

Show comment Hide comment
@qxfusion

qxfusion Dec 28, 2012

It's note for CURRENT implementation for Linux. I'm think more information can be see in source code.

@qxfusion

qxfusion Dec 28, 2012

It's note for CURRENT implementation for Linux. I'm think more information can be see in source code.

+Note: For Linux "process name" string can't be length more 16 bytes.
+Note: This is build-in function and can't be overload or override via Object.defineProperty.
+Known issue: For Linux return full string of process, but setup as "process name" only first 16 bytes.
+Known issue: For Linux not check Latin1 (ASCII/ANSI) string charset, using non-ASCII(ANSI) charset may create problem on system with different encoding and without UTF-8 support.
## process.arch

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Dec 28, 2012

Member

I'm afraid it also contains a fair bit of Engrish, both in spelling ('avaible', 'build-in', etc.) and grammar.

@bnoordhuis

bnoordhuis Dec 28, 2012

Member

I'm afraid it also contains a fair bit of Engrish, both in spelling ('avaible', 'build-in', etc.) and grammar.

This comment has been minimized.

Show comment Hide comment
@qxfusion

qxfusion Dec 28, 2012

About English - I'm dont understand you. What are you want - please more accuracy you request?

@qxfusion

qxfusion Dec 28, 2012

About English - I'm dont understand you. What are you want - please more accuracy you request?

This comment has been minimized.

Show comment Hide comment
@Mithgol

Mithgol Dec 29, 2012

Engrish is a slang term for the misuse of the English language by native speakers of some East Asian languages.

At least the following needs to be fixed:

  • OS specification don't (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • don't provide method change "process name" on-the-fly (lacks a preposition, at least)
  • 'ps' don't work (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • change "process name" avaible only (the statement lacks a verb, and avaible's spelling is wrong)
  • function don't have effect (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • string can't be length more 16 bytes (wrong grammatical government
  • This is build-in function (some article is missing)
  • can't be overload or override (verbs overload and override should appear in the passive voice)
  • return full string of process, but setup as "process name" only first 16 bytes (wrong grammatical number and grammatical person of the verbs; should be third-person singular)
  • For Linux not check Latin1 (ASCII/ANSI) string charset (wrong negation and grammatical number and grammatical person)

Of course I could fix that myself, but that would require me signing the CLA, which I am not ready to sign yet.

@Mithgol

Mithgol Dec 29, 2012

Engrish is a slang term for the misuse of the English language by native speakers of some East Asian languages.

At least the following needs to be fixed:

  • OS specification don't (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • don't provide method change "process name" on-the-fly (lacks a preposition, at least)
  • 'ps' don't work (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • change "process name" avaible only (the statement lacks a verb, and avaible's spelling is wrong)
  • function don't have effect (this grammatical number and grammatical person of the verb is wrong here; should be third-person singular)
  • string can't be length more 16 bytes (wrong grammatical government
  • This is build-in function (some article is missing)
  • can't be overload or override (verbs overload and override should appear in the passive voice)
  • return full string of process, but setup as "process name" only first 16 bytes (wrong grammatical number and grammatical person of the verbs; should be third-person singular)
  • For Linux not check Latin1 (ASCII/ANSI) string charset (wrong negation and grammatical number and grammatical person)

Of course I could fix that myself, but that would require me signing the CLA, which I am not ready to sign yet.

@qxfusion qxfusion closed this Dec 29, 2012

@qxfusion qxfusion deleted the qxfusion:patch-2 branch Dec 29, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.