Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix build on Raspberry Pi #4534

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Pitel commented Jan 8, 2013

See issue #4142!
Builds fine on v0.8 branch.
Values taken from standalone.gypi.

Fix build on Raspberry Pi
See issue 4142!
Build fine on v0.8 branch.
Values taken from standalone.gypi.

Pitel commented Jan 8, 2013

git bisect, 7b4d95a is the breaking commit!

Member

bnoordhuis commented Jan 8, 2013

Please see the CONTRIBUTING guide, we don't take V8 patches. If you can get it to work by tweaking the configure script, I'll be happy to merge it.

TooTallNate added a commit to TooTallNate/node that referenced this pull request Jan 10, 2013

configure: on ARM, always define the "arm_fpu" and "arm_neon" variables
v8's common.gypi file expects them to be defined now.
See: #4534

Can somebody (preferably @bnoordhuis) review TooTallNate/node@4f4c5a0?

@Pitel Thanks for the report. Fixed in b916774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment