This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
TypedArrays: Fix size/index overflow on 32-bit. #4550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been added as a result of misreading the spec, there is no get() method, only a getter (which the spec names get()), but this is actually the [] operator. There are many webkit tests that explicitly test for the fact that the get() method is abscent. Remove it to conform to the spec.
It seems that like get(), set(index, val) was added as a misreading of the spec.
There are only two set() methods defined in the spec:
void set(TypedArray array, optional unsigned long offset)
void set(type[] array, optional unsigned long offset)
The set(index, val) is handled by the []= operator.
Additionally updated a few exception error strings to match WebKit.
On 64-bit, the calculation is promoted to a 64-bit int. However on 32-bit the int will be 32-bit and the index + size calculation can overflow. Rearrange the math to prevent overflow and add a few more checks for additional safety. The size should never be less than 0, for example, but we check anyway.
|
For posterity, this PR doesn't apply to v0.8 so I've landed a fix for the overflow bug in ed825f4. |
|
Yeah, it depends on #4547. Perhaps I will make a future patch that cleans up overall some of the signed/unsigned-ness throughout the code. A bit awkward sometimes between the V8 api and the TypedArray spec. Thanks for patching it against 0.8. |
|
Can one of the admins verify this patch? |
|
We now use typed arrays directly from V8, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4547