This repository has been archived by the owner. It is now read-only.

lib, src: remove errno global #4874

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Member

bnoordhuis commented Feb 28, 2013

Remove the errno global. It's a property on the process object now.

Fixes #3095.

Reviewer: @isaacs or @TooTallNate

lib, src: remove errno global
Remove the errno global. It's a property on the process object now.

Fixes #3095.

Well that was easier a patch than I thought it would be...

I haven't grep'd to make sure you didn't miss any, but preliminary LGTM.

Member

bnoordhuis commented Feb 28, 2013

Ideally, the bindings should return an error code instead of setting it as a property on an object. But at least the global is gone now.

isaacs commented Feb 28, 2013

If tests pass, please land. Rubber-stamp LGTM: +1 on the feature, and nothing looks horribly amiss.

Member

bnoordhuis commented Feb 28, 2013

Landed in 12d0f0b.

@bnoordhuis bnoordhuis closed this Feb 28, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.