Skip to content
This repository has been archived by the owner. It is now read-only.

events: remove type check for event type #4915

Merged
merged 2 commits into from Mar 4, 2013

Conversation

@trevnorris
Copy link

commented Mar 4, 2013

Strict checking for typeof types broke backwards compatibility for other
libraries. This reverts those checks.

events: remove type check for event type
Strict checking for typeof types broke backwards compatibility for other
libraries. This reverts those checks.

The subclass test has been changed to ensure all operations can be
performed on the inherited EE before instantiation. Including the
ability to set event names with numbers.
events: code consistency
v8 likes when smaller functions have a single return point, and cleaned
up the single non-strict check.
@piscisaureus

This comment has been minimized.

Copy link
Member

commented Mar 4, 2013

LGTM

@piscisaureus piscisaureus merged commit d09ab61 into nodejs:master Mar 4, 2013

@mscdex

This comment has been minimized.

Copy link

commented on 0468861 Mar 4, 2013

+10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.