cares: Set process._errno, not global.errno #4933

Closed
wants to merge 1 commit into
from

3 participants

@isaacs

This makes test-internet pass

@isaacs

@bnoordhuis Please review. I'm sure that there's a more lovely way to do this, but this at least makes the test pass.

@isaacs

Vaguely related: There's some errno stuff in src/node_file.cc that seems extraneous as well. But it's not causing any tests to fail.

@indutny
Node.js Foundation member

We should probably export static process object from src/node.cc to node_internals.h and use it. Doing lookup in context's global doesn't feel like a right thing to me. And potentially unsafe.

This was referenced Mar 6, 2013
@indutny
Node.js Foundation member

LGTM, landed in 74784b6

@indutny indutny closed this Mar 6, 2013
@bnoordhuis
Node.js Foundation member

Another (belated) LGTM.

@bnoordhuis
Node.js Foundation member

Vaguely related: There's some errno stuff in src/node_file.cc that seems extraneous as well.

It's unused. Removed in 3dbbfd7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment