tls: Destroy socket when encrypted side closes #5170

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

isaacs commented Mar 30, 2013

The v0.8 Stream.pipe() method automatically destroyed the destination
stream whenever the src stream closed. However, this caused a lot of
problems, and was removed by popular demand. (Many userland modules
still have a no-op destroy() method just because of this.) It was also
very hazardous because this would be done even if { end: false } was
passed in the pipe options.

In v0.10, we decided that the 'close' event and destroy() method are
application-specific, and pipe() doesn't automatically call destroy().
However, TLS actually depended (silently) on this behavior. So, in this
case, we should just go ahead and destroy the thing when close happens.

Closes #5145

@isaacs isaacs tls: Destroy socket when encrypted side closes
The v0.8 Stream.pipe() method automatically destroyed the destination
stream whenever the src stream closed.  However, this caused a lot of
problems, and was removed by popular demand.  (Many userland modules
still have a no-op destroy() method just because of this.) It was also
very hazardous because this would be done even if { end: false } was
passed in the pipe options.

In v0.10, we decided that the 'close' event and destroy() method are
application-specific, and pipe() doesn't automatically call destroy().
However, TLS actually depended (silently) on this behavior.  So, in this
case, we should just go ahead and destroy the thing when close happens.

Closes #5145
426de20

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Your commits have changes to lib or src but have no corresponding test or benchmark to go with them.

Please see CONTRIBUTING.md for more information

indutny was assigned Mar 30, 2013

Hahah, nice @Nodejs-Jenkins!

You get what you ask for

isaacs commented Apr 1, 2013

landed in v0.10.

isaacs closed this Apr 1, 2013

isaacs deleted the isaacs:GH-5145 branch Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment