Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Unnecessary binding #5184

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

mitar commented Mar 31, 2013

There is no need for this variable, it is not used anywhere.

Owner

bnoordhuis commented Mar 31, 2013

There's already a PR for that, #5167. First one to sign the CLA and reword the commit log to something nice wins. See https://github.com/joyent/node/blob/master/CONTRIBUTING.md for details.

mitar commented Mar 31, 2013

I already signed CLA some time ago. :-) I am not sure about rewording, what exactly should be changed?

mitar commented Mar 31, 2013

Sorry, lying. Not signed yet anything for node.js itself. :-)

@mitar mitar querystring: Removing unnecessary binding
There was unused binding of "http_parser" in the module, which is now
removed.
2473b53

mitar commented Mar 31, 2013

Signed and improved the wording.

Owner

indutny commented Apr 1, 2013

Thanks, landed with small changes in e5b90a1.

@indutny indutny closed this Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment