cherry pick recent dtrace fixes to v0.10 #5201

Closed
wants to merge 5 commits into
from

Projects

None yet

5 participants

@tjfontaine

This enables dtrace on osx as well as setting the fd field properly in the probes

davepacheco and others added some commits Mar 28, 2013
@davepacheco @tjfontaine davepacheco build: allow building with dtrace on osx aab53bb
@davepacheco @tjfontaine davepacheco dtrace: pass more arguments to probes
OSX and other DTrace implementations don't support dereferencing
structs in probes. To accomodate that pass members from the struct as
arguments so that DTrace is useful on those systems.
f796792
@tjfontaine tjfontaine dtrace: actually use the _handle.fd value
When using the DTrace/systemtap subsystems it would be helpful to
actually have an fd associated with the requests and responses.
7a43e8f
@bnoordhuis @tjfontaine bnoordhuis dtrace: check if _handle property is set
Check that _handle is an object before trying to read its `fd`
property, avoids bogus values.
a5f82b0
@tjfontaine tjfontaine etw: update prototypes to match dtrace provider
The DTrace probes were updated to accomodate platforms that can't
handle structs, update the prototypes for ETW but it's not necessary
to do anything with the new arguments as it's redundant information.
b8bb9f1
@Nodejs-Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • Dave Pacheco

Please see CONTRIBUTING.md for more information

@bnoordhuis
Member

Rubberstamp LGTM.

@isaacs
isaacs commented Apr 3, 2013

Landed in 0.10

@isaacs isaacs closed this Apr 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment