Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add an npm link above the homepage fold #5203

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Well, to be honest, I'm a bit nervous to actually start contributing to core, so I thought I'd wean myself on by doing some bitesize/website stuff.

So, here it is. I'm by no means a designer, so it might not be perfect, but it's a practice pull request anyways.

Fixes joyent/node#4077.

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit josephwegner/node@63173b0 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

Please see CONTRIBUTING.md for more information

web: Add an npm link above the homepage fold
Add a third button underneath the INSTALL button that links
to http://search.npmjs.org

Fixes nodejs/node-v0.x-archive#4077.

Sorry Jenkins. Not sure if "web" is really a subsystem, but hopefully that works.

By the way, I HAVE already filled out the CLA

isaacs commented Apr 3, 2013

@josephwegner Don't mind @Nodejs-Jenkins, he's just upset because he can never be a real boy.

Please don't be discouraged, but I don't think this patch is a good idea. We've tried to keep the "download" and "install" section as un-cluttered as we can get away with, and adding another button is a step back.

But now you've been through the process, so if you ever find a bug or want to fix some documentation, you've got nothing stopping you :)

@isaacs isaacs closed this Apr 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment