Added glob-matching to events. #6591

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@kkragenbrink

No description provided.

@Nodejs-Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit kkragenbrink/node@c1d2cc8 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

The following commiters were not found in the CLA:

  • Kevin Kragenbrink

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@rlidwka
Member
rlidwka commented Nov 27, 2013

Considering how widely events are used in the code, I wonder what performance guys would say about that.

@kkragenbrink

Admittedly, I didn't check performance, but this should be about the most performant way TO do glob-matching, and EventEmitter really needs to support it for a proper event system. I keep having to hack this into place on most of my systems by extending the class. Having it in core would, obviously, be far less annoying.

@rlidwka
Member
rlidwka commented Nov 27, 2013

Admittedly, I didn't check performance, but this should be about the most performant way TO do glob-matching

The most performant way would be to not do glob-matching at all unless there is at least one listener who tries to take advantage of it. I'm not even talking about caching regexes.

I keep having to hack this into place on most of my systems by extending the class.

Same here. Actually, talk about this feature goes for a while now (#1478, #1457) and doesn't seem to be accepted. I'd support it though.

@isaacs
isaacs commented Nov 27, 2013

No thanks. The events module is frozen. We won't be adding any more features to it. Something like this belongs in userland.

@isaacs isaacs closed this Nov 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment