Revert "src: only define ssize_t on windows if undefined" #6992

Closed
wants to merge 1 commit into
from

4 participants

@bnoordhuis
Node.js Foundation member

Reverted for breaking building add-ons on Linux, OS X and probably
other UNIX platforms. See nodejs/nan#66 for an example.

This reverts commit ab54e32.

/cc @tjfontaine @indutny

@bnoordhuis bnoordhuis Revert "src: only define ssize_t on windows if undefined"
Reverted for breaking building add-ons on Linux, OS X and probably
other UNIX platforms.  See nodejs/nan#66 for an example.

This reverts commit ab54e32.
cc6b136
@Nodejs-Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit bnoordhuis/node@cc6b136 has the following error(s):

  • First line of commit message must be no longer than 50 characters

The following commiters were not found in the CLA:

  • Ben Noordhuis

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@bnoordhuis bnoordhuis referenced this pull request in nodejs/nan Jan 29, 2014
Closed

Node 0.11.11 errors #66

@indutny
Node.js Foundation member

Oh @tjfontaine I missed that you declared it in namespace, could you do it right before it?

@tjfontaine

sigh, yes sorry

@tjfontaine tjfontaine added a commit that closed this pull request Jan 29, 2014
@tjfontaine tjfontaine src: move header inclusion out of namespace
The placement of a previous fix to include proper size_t types in
addons was erroneously placed inside a namespace, move to just before.

Fix #6992
c8c26f1
@bnoordhuis bnoordhuis referenced this pull request in bnoordhuis/node-buffertools Jan 30, 2014
Closed

pretty broken on v0.11.11 #53

@bnoordhuis bnoordhuis deleted the bnoordhuis:revert-ab54e32 branch Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment