Skip to content

Loading…

Update the v0.10 CA certificates to match the CA certificates in v0.11 #7037

Closed
wants to merge 1 commit into from

5 participants

@mdlavin

I was hitting a SSL certificate validation issue when using node v0.10 when I realized that the latest Go Daddy root certificates were not including the v0.10. It looks like this issue was covered in nodejs/node-v0.x-archive#6489 and nodejs/node-v0.x-archive#6013, but those changes are only in the v0.11 branch.

I've pulled the related changes from v0.11 and merged them into the v0.10 branch. Is it possible to get the updates included in v0.10?

@Nodejs-Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit mdlavin/node@f43ce90 has the following error(s):

  • Commit message line too long: 5

The following commiters were not found in the CLA:

  • Ben Noordhuis

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@mdlavin

The "Commit message line too long" problem was mentioned in issue 6489 and Ben's response was:

I know and that's not going to get fixed, Jenkins bot. It's a URL.
@indutny
Node.js Foundation member

I have no objections to it, and ok with pulling it.

@tjfontaine is it ok to do this in a stable branch?

@tjfontaine

I am fine if we just grab the certs header that was updated, I see no reason to include the rest of that change here.

@mdlavin

Funny, I was afraid somebody would say the opposite, so I made sure to take all the related changes. My logic was that since the file was generated, it would make maintenance easier if the tools were available as well. Should I update my stream to have only the one header change?

@tjfontaine

that would be my preference yes

@bnoordhuis bnoordhuis crypto: update root certificates
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl and update src/node_crypto.cc to make use of
the new format.

Fixes #6013.
362194b
@mdlavin

Ok, my branch has been updated to have only the header / source update. No tool related changes.

@indutny
Node.js Foundation member

Thank you, landed in 09c51d5

@indutny indutny closed this
@mmalecki mmalecki referenced this pull request in request/request
Closed

Update CA Certs used? #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 3, 2014
  1. @bnoordhuis @mdlavin

    crypto: update root certificates

    bnoordhuis committed with mdlavin
    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl and update src/node_crypto.cc to make use of
    the new format.
    
    Fixes #6013.
Something went wrong with that request. Please try again.