Assert in new context #706

Closed
wants to merge 2 commits into
from

6 participants

@lukebayes

This is patch that helps make assert.throws work properly within new contexts.

#693

@lukebayes

Just checking in here to see if you'll be able to pull this, or if I should provide some other updates?

Thanks,

Luke

@ELLIOTTCABLE

Any particular reason this hasn’t been pulled yet? I am in need of this functionality too.

@trevnorris

This pull request now has a few conflicts in test/simple/test-script-context.js. Will need to be resolved.

@bnoordhuis
Node.js Foundation member

I don't mind landing this but it needs to be rebased against master.

@trevnorris trevnorris referenced this pull request Dec 5, 2012
Closed

Assert in new context #4370

@trevnorris

@bnoordhuis I've taken the branch and rebased it against master in #4370.

@Nodejs-Jenkins

Can one of the admins verify this patch?

@hackedy

Hey, this can be closed. It got moved over to #4370 and closed there. /cc @isaacs @bnoordhuis

@bnoordhuis bnoordhuis closed this Apr 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment