Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

build: skip vcvarsall if already set up #7087

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants

mscdex commented Feb 9, 2014

Without this, running vcbuild repeatedly for some time will cause errors with msbuild saying the command line is too long (due to concatenation happening in vcvarsall).

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • Brian White

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

Owner

indutny commented Feb 14, 2014

Assigning to @tjfontaine

@trevnorris trevnorris added the build label Feb 18, 2014

Owner

jasnell commented Aug 13, 2015

@mscdex ... is this still needed?

mscdex commented Aug 13, 2015

@jasnell From what I can tell by looking at the latest vcbuild.bat, yes. However it looks like the spot where the check needs to go has to be changed.

@jasnell jasnell self-assigned this Aug 13, 2015

Member

orangemocha commented Aug 14, 2015

This was fixed with d22637c. Thanks anyway, @mscdex !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment