Skip to content


Subversion checkout URL

You can clone with
Download ZIP


build: skip vcvarsall if already set up #7087

wants to merge 1 commit into from

7 participants


Without this, running vcbuild repeatedly for some time will cause errors with msbuild saying the command line is too long (due to concatenation happening in vcvarsall).


Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

The following commiters were not found in the CLA:

  • Brian White

You can fix all these things without opening another issue.

Please see for more information

@tjfontaine tjfontaine was assigned by indutny

Assigning to @tjfontaine

@trevnorris trevnorris added the build label

@mscdex ... is this still needed?

@tjfontaine tjfontaine was unassigned by jasnell

@jasnell From what I can tell by looking at the latest vcbuild.bat, yes. However it looks like the spot where the check needs to go has to be changed.

@jasnell jasnell self-assigned this

This was fixed with d22637c. Thanks anyway, @mscdex !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 9, 2014
  1. @mscdex
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 vcbuild.bat
5 vcbuild.bat
@@ -96,9 +96,11 @@ SETLOCAL
-@rem Skip project generation if requested.
+@rem Skip project build if requested.
if defined nobuild goto sign
+if defined VCINSTALLDIR goto msbuild-found
@rem Look for Visual Studio 2013
if not defined VS120COMNTOOLS goto vc-set-2012
if not exist "%VS120COMNTOOLS%\..\..\vc\vcvarsall.bat" goto vc-set-2012
@@ -121,6 +123,7 @@ if not defined VS100COMNTOOLS goto msbuild-not-found
if not exist "%VS100COMNTOOLS%\..\..\vc\vcvarsall.bat" goto msbuild-not-found
call "%VS100COMNTOOLS%\..\..\vc\vcvarsall.bat"
if not defined VCINSTALLDIR goto msbuild-not-found
goto msbuild-found
Something went wrong with that request. Please try again.