This repository has been archived by the owner. It is now read-only.

child_process: accept `uid`/`gid` everywhere #7882

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@indutny
Member

indutny commented Jul 2, 2014

Accept uid/gid option in every execute/spawn call (including
cluster.fork). Add documentation where needed.

fix #7881

child_process: accept `uid`/`gid` everywhere
Accept `uid`/`gid` option in every execute/spawn call (including
`cluster.fork`). Add documentation where needed.

fix #7881
@trevnorris

This comment has been minimized.

Show comment Hide comment
@trevnorris

trevnorris Jul 2, 2014

LGTM

LGTM

@indutny

This comment has been minimized.

Show comment Hide comment
@indutny

indutny Jul 2, 2014

Member

Please land it :)

Member

indutny commented Jul 2, 2014

Please land it :)

@trevnorris

This comment has been minimized.

Show comment Hide comment
@trevnorris

trevnorris Jul 2, 2014

merged in ae1e325.

merged in ae1e325.

@trevnorris trevnorris closed this Jul 2, 2014

@hdn8

This comment has been minimized.

Show comment Hide comment
@hdn8

hdn8 Jul 3, 2014

Tested in my app and works like a charm, should note though that for child_process the uid/gid must be numbers, while process accepts string usernames (as noted by joyent#5824) -- fyi.

hdn8 commented Jul 3, 2014

Tested in my app and works like a charm, should note though that for child_process the uid/gid must be numbers, while process accepts string usernames (as noted by joyent#5824) -- fyi.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.