Navigation Menu

Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

build: add win32 convenience build rule #9085

Closed
wants to merge 1 commit into from

Conversation

tjfontaine
Copy link

Make sure the windows release builds are built with the same options as the unix builds.

@misterdjules
Copy link

LGTM, and tested on Windows 7 with vcbuild build-release nosign. Here's what I got:

> process.config
{ target_defaults:
   { cflags: [],
     default_configuration: 'Release',
     defines: [],
     include_dirs: [],
     libraries: [] },
  variables:
   { clang: 0,
     host_arch: 'x64',
     node_install_npm: true,
     node_prefix: '',
     node_shared_cares: false,
     node_shared_http_parser: false,
     node_shared_libuv: false,
     node_shared_openssl: false,
     node_shared_v8: false,
     node_shared_zlib: false,
     node_tag: '',
     node_unsafe_optimizations: 0,
     node_use_dtrace: false,
     node_use_etw: true,
     node_use_openssl: true,
     node_use_perfctr: true,
     node_use_systemtap: false,
     openssl_no_asm: 0,
     python: 'C:\\Python27\\python.exe',
     target_arch: 'ia32',
     v8_enable_gdbjit: 0,
     v8_no_strict_aliasing: 1,
     v8_use_snapshot: false,
     visibility: '',
     want_separate_host_toolset: 0 } }
> process.version
'v0.10.36-pre'
>

@misterdjules misterdjules added this to the 0.10.36 milestone Jan 23, 2015
tjfontaine added a commit that referenced this pull request Jan 23, 2015
PR-URL: #9085
PR: #9085

Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
@tjfontaine
Copy link
Author

thanks landed in 6168fe6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants