Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[tls] write data by small (1500 bytes) chunks, see http://www.belshe.com/ #961
This pull request was previously posted here, but this time it's low-level:
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I'm concerned about the effect this might have on throughput, and thats what it would be nice to have a benchmark of -- showing the effect is negligible.
1500 byte writes to SSL_write also would cause a bad behavior for many connections, because that would become 1500+ bytes with the TLS headers/protocol, and for most MTUs would end up being 2 packets instead of 1. (good thing to look at in wireshark over non-localhost)
If the benchmark shows this isn't a huge drop in throughput, I'd be interested in seeing what happens with using ~1300-1400 byte writes, which should drop you bellow the common MTUs.