Skip to content
Permalink
Branch: canary
Commits on Aug 9, 2019
  1. util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols

    ljharb authored and devsnek committed Aug 7, 2019
    ... before trying to valueOf them
    
    PR-URL: nodejs/node#29029
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. util: assert: fix deepEqual comparing fake-boxed to real boxed primitive

    ljharb authored and devsnek committed Aug 6, 2019
    PR-URL: nodejs/node#29029
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  3. test: assert: add failing deepEqual test for faked boxed primitives

    ljharb authored and devsnek committed Aug 6, 2019
    PR-URL: nodejs/node#29029
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
You can’t perform that action at this time.