Please sign in to comment.
http2: keep session objects alive during Http2Scope
Keep a local handle as a reference to the JS `Http2Session` object so that it will not be garbage collected when inside an `Http2Scope`, because the presence of the latter usually indicates that further actions on the session object are expected. Strictly speaking, storing the `session_handle_` as a property on the scope object is not necessary, but this is not very costly and makes the code more obviously correct. Fixes: #17840 PR-URL: #17863 Fixes: #17840 Reviewed-By: Anatoli Papirovski <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com>
- Loading branch information...
Showing with 19 additions and 0 deletions.