Permalink
Browse files

test: don't connect to :: (use localhost instead)

If a test does http.listen(0) or net.listen(0),
http.listen(0).address().address returns '::'. Some machines will
resolve this to localhost, but not all. Every machine should have
localhost defined in /etc/hosts (or equivalent), so it should always
resolve.

Fixes: #7291
PR-URL: #10854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michal Zasso <targos@protonmail.com>
  • Loading branch information...
gibfahn authored and jasnell committed Jan 17, 2017
1 parent dcab88d commit 067be658f966dafe3d16bdd7b5bbb7c5e58c7250
Showing with 2 additions and 4 deletions.
  1. +1 −1 test/gc/test-net-timeout.js
  2. +1 −3 test/parallel/test-http-status-reason-invalid-chars.js
@@ -35,7 +35,7 @@ function getall() {
if (count >= todo)
return;
const req = net.connect(server.address().port, server.address().address);
const req = net.connect(server.address().port);
req.resume();
req.setTimeout(10, function() {
req.destroy();
@@ -3,7 +3,6 @@
const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');
function explicit(req, res) {
assert.throws(() => {
@@ -34,8 +33,7 @@ const server = http.createServer((req, res) => {
implicit(req, res);
}
}).listen(0, common.mustCall(() => {
const addr = server.address().address;
const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
const hostname = 'localhost';
const url = `http://${hostname}:${server.address().port}`;
let left = 2;
const check = common.mustCall((res) => {

0 comments on commit 067be65

Please sign in to comment.