diff --git a/src/node.cc b/src/node.cc index 2395f28c7b8cb7..5d730985bfea4a 100644 --- a/src/node.cc +++ b/src/node.cc @@ -800,12 +800,6 @@ static ExitCode ProcessGlobalArgsInternal(std::vector* args, return ExitCode::kInvalidCommandLineArgument2; } - // TODO(aduh95): remove this when the harmony-import-assertions flag - // is removed in V8. - if (std::find(v8_args.begin(), v8_args.end(), - "--no-harmony-import-assertions") == v8_args.end()) { - v8_args.emplace_back("--harmony-import-assertions"); - } // TODO(aduh95): remove this when the harmony-import-attributes flag // is removed in V8. if (std::find(v8_args.begin(), @@ -813,6 +807,9 @@ static ExitCode ProcessGlobalArgsInternal(std::vector* args, "--no-harmony-import-attributes") == v8_args.end()) { v8_args.emplace_back("--harmony-import-attributes"); } + // TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default + // anymore. + v8_args.emplace_back("--no-harmony-import-assertions"); auto env_opts = per_process::cli_options->per_isolate->per_env; if (std::find(v8_args.begin(), v8_args.end(), diff --git a/test/es-module/test-esm-import-attributes-errors.js b/test/es-module/test-esm-import-attributes-errors.js index 828ded7e684342..63513a51e5abb5 100644 --- a/test/es-module/test-esm-import-attributes-errors.js +++ b/test/es-module/test-esm-import-attributes-errors.js @@ -55,6 +55,16 @@ async function test() { import(jsonModuleDataUrl, { with: { type: 'unsupported' } }), { code: 'ERR_IMPORT_ATTRIBUTE_UNSUPPORTED' } ); + + await rejects( + import(jsonModuleDataUrl, { assert: { type: 'json' } }), + { code: 'ERR_IMPORT_ATTRIBUTE_MISSING' } + ); + + await rejects( + import(`data:text/javascript,import${JSON.stringify(jsonModuleDataUrl)}assert{type:"json"}`), + SyntaxError + ); } test().then(common.mustCall()); diff --git a/test/es-module/test-esm-import-attributes-errors.mjs b/test/es-module/test-esm-import-attributes-errors.mjs index 887a1b97cc26ee..d7ffc6f92c99ea 100644 --- a/test/es-module/test-esm-import-attributes-errors.mjs +++ b/test/es-module/test-esm-import-attributes-errors.mjs @@ -50,3 +50,13 @@ await rejects( import(jsonModuleDataUrl, { with: { type: 'unsupported' } }), { code: 'ERR_IMPORT_ATTRIBUTE_UNSUPPORTED' } ); + +await rejects( + import(jsonModuleDataUrl, { assert: { type: 'json' } }), + { code: 'ERR_IMPORT_ATTRIBUTE_MISSING' } +); + +await rejects( + import(`data:text/javascript,import${JSON.stringify(jsonModuleDataUrl)}assert{type:"json"}`), + SyntaxError +);