Permalink
Browse files

build: fail on instrumentation errors

nyc was silently failing to instrument new language features,
resulting in a failure to instrument console.js.

Refs: #20952
  • Loading branch information...
bcoe committed Jun 1, 2018
1 parent 148b8ad commit 09011f0c1ce11074e09317114626393517c9bd37
Showing with 2 additions and 1 deletion.
  1. +2 −1 Makefile
@@ -176,7 +176,8 @@ coverage-build: all
"$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi
if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi
mv lib lib_
$(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/
NODE_DEBUG=nyc $(NODE) ./node_modules/.bin/nyc instrument --extension .js \
--extension .mjs --exit-on-error lib_/ lib/
$(MAKE)
.PHONY: coverage-test

0 comments on commit 09011f0

Please sign in to comment.