Skip to content
Permalink
Browse files

doc: standardizing on make -j4

Standardizes docs to use -j4 instead of -j8 as it appears to be the
most inclusive recommendation based on discussion in
#9961.

PR-URL: #9961
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
  • Loading branch information...
jmdarling authored and Fishrock123 committed Dec 6, 2016
1 parent cffbb32 commit 0cd1f54fab3f35c6f53a6106cd9b5299c2c67413
Showing with 5 additions and 5 deletions.
  1. +1 −1 .github/PULL_REQUEST_TEMPLATE.md
  2. +2 −2 CONTRIBUTING.md
  3. +1 −1 doc/guides/building-node-with-ninja.md
  4. +1 −1 doc/onboarding-extras.md
@@ -9,7 +9,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
- [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [ ] commit message follows commit guidelines
@@ -156,7 +156,7 @@ to see how they should be structured can also help.
To run the tests on Unix / OS X:

```text
$ ./configure && make -j8 test
$ ./configure && make -j4 test
```

Windows:
@@ -189,7 +189,7 @@ You can run tests directly with node:
$ ./node ./test/parallel/test-stream2-transform.js
```

Remember to recompile with `make -j8` in between test runs if you change
Remember to recompile with `make -j4` in between test runs if you change
core modules.

### Step 6: Push
@@ -16,7 +16,7 @@ ninja: Entering directory `out/Release`

The bottom line will change while building, showing the progress as `[finished/total]` build steps.
This is useful output that `make` does not produce and is one of the benefits of using Ninja.
Also, Ninja will likely compile much faster than even `make -j8` (or `-j<number of processor threads on your machine>`).
Also, Ninja will likely compile much faster than even `make -j4` (or `-j<number of processor threads on your machine>`).

## Considerations

@@ -71,7 +71,7 @@ Please use these when possible / appropriate
* major vs. everything else: run last versions tests against this version, if they pass, **probably** minor or patch
* A breaking change helper ([full source](https://gist.github.com/chrisdickinson/ba532fa0e4e243fb7b44)):
```sh
git checkout $(git show -s --pretty='%T' $(git show-ref -d $(git describe --abbrev=0) | tail -n1 | awk '{print $1}')) -- test; make -j8 test
git checkout $(git show -s --pretty='%T' $(git show-ref -d $(git describe --abbrev=0) | tail -n1 | awk '{print $1}')) -- test; make -j4 test
```


0 comments on commit 0cd1f54

Please sign in to comment.
You can’t perform that action at this time.