Skip to content
Permalink
Browse files

test: Remove unnecessary asserion messages in test-crypto-hash.js

This commit improves asserion messages in parallel/test-crypto-hash.js.
Instead of just simple string literal, messages are changed to also
include values used in assertion, which should improve debugging
in case of errors.

PR-URL: #18984
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
pgrzesik authored and BridgeAR committed Mar 11, 2018
1 parent ebfa8b1 commit 0e35683876bfe0a9c008865232bfabc974e3ddd3
Showing with 5 additions and 5 deletions.
  1. +5 −5 test/parallel/test-crypto-hash.js
@@ -82,15 +82,15 @@ assert.deepStrictEqual(
);

// stream interface should produce the same result.
assert.deepStrictEqual(a5, a3, 'stream interface is consistent');
assert.deepStrictEqual(a6, a3, 'stream interface is consistent');
assert.notStrictEqual(a7, undefined, 'no data should return data');
assert.notStrictEqual(a8, undefined, 'empty string should generate data');
assert.deepStrictEqual(a5, a3);
assert.deepStrictEqual(a6, a3);
assert.notStrictEqual(a7, undefined);
assert.notStrictEqual(a8, undefined);

// Test multiple updates to same hash
const h1 = crypto.createHash('sha1').update('Test123').digest('hex');
const h2 = crypto.createHash('sha1').update('Test').update('123').digest('hex');
assert.strictEqual(h1, h2, 'multipled updates');
assert.strictEqual(h1, h2);

// Test hashing for binary files
const fn = fixtures.path('sample.png');

3 comments on commit 0e35683

@tniessen

This comment has been minimized.

Copy link
Member

@tniessen tniessen replied Mar 11, 2018

The commit message should have followed the commit message guidelines, there are typos and the description does not match the actual change.

@BridgeAR

This comment has been minimized.

Copy link
Member

@BridgeAR BridgeAR replied Mar 11, 2018

It does. We accept longer names even though it is nicer to keep them short.

@Trott

This comment has been minimized.

Copy link
Member

@Trott Trott replied Mar 11, 2018

@BridgeAR Remove (instead of remove) might be what @tniessen is talking about. (Also, the misspelling of assertion, but that's a simple typo and not a commit message formatting issue.)

Please sign in to comment.