Permalink
3 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
test: Remove unnecessary asserion messages in test-crypto-hash.js
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. PR-URL: #18984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
- Loading branch information
This comment has been minimized.
The commit message should have followed the commit message guidelines, there are typos and the description does not match the actual change.
This comment has been minimized.
It does. We accept longer names even though it is nicer to keep them short.
This comment has been minimized.
@BridgeAR
Remove
(instead ofremove
) might be what @tniessen is talking about. (Also, the misspelling ofassertion
, but that's a simple typo and not a commit message formatting issue.)