From 0f3e65099da9b6104321cfd19407d5b13fc4db85 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 15 Jun 2018 02:15:04 +0200 Subject: [PATCH] http2: fix memory leak for uncommon headers Fix a memory leak that occurs with header names that are short and not present in the static table of default headers. Backport-PR-URL: https://github.com/nodejs/node/pull/22850 PR-URL: https://github.com/nodejs/node/pull/21336 Reviewed-By: Anatoli Papirovski Reviewed-By: James M Snell Reviewed-By: Minwoo Jung Reviewed-By: Richard Lau Reviewed-By: Tiancheng "Timothy" Gu --- src/node_http2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_http2.h b/src/node_http2.h index f054ff9e9d6a26..67af832eff78b7 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -1299,6 +1299,7 @@ class ExternalHeader : } if (may_internalize && vec.len < 64) { + nghttp2_rcbuf_decref(buf); // This is a short header name, so there is a good chance V8 already has // it internalized. return GetInternalizedString(env, vec);