From 1063e0c92cf0283d964a222c78bb0a952f8b55a9 Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Sat, 24 Nov 2018 00:31:52 +0200 Subject: [PATCH] lib: fix comment nits in bootstrap\loaders.js PR-URL: https://github.com/nodejs/node/pull/24641 Reviewed-By: Luigi Pinca Reviewed-By: Franziska Hinkelmann --- lib/internal/bootstrap/loaders.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js index 78e1180dde2af2..02abc683072ae2 100644 --- a/lib/internal/bootstrap/loaders.js +++ b/lib/internal/bootstrap/loaders.js @@ -19,7 +19,7 @@ // can be created using NODE_MODULE_CONTEXT_AWARE_CPP() with the flag // NM_F_LINKED. // - internalBinding(): the private internal C++ binding loader, inaccessible -// from user land because they are only available from NativeModule.require() +// from user land because they are only available from NativeModule.require(). // These C++ bindings are created using NODE_MODULE_CONTEXT_AWARE_INTERNAL() // and have their nm_flags set to NM_F_INTERNAL. // @@ -61,7 +61,7 @@ keys: ObjectKeys, } = Object; - // Set up process.moduleLoadList + // Set up process.moduleLoadList. const moduleLoadList = []; ObjectDefineProperty(process, 'moduleLoadList', { value: moduleLoadList, @@ -71,7 +71,7 @@ }); // internalBindingWhitelist contains the name of internalBinding modules - // that are whitelisted for access via process.binding()... this is used + // that are whitelisted for access via process.binding()... This is used // to provide a transition path for modules that are being moved over to // internalBinding. const internalBindingWhitelist = [ @@ -105,7 +105,7 @@ // for checking existence in this list. let internalBindingWhitelistSet; - // Set up process.binding() and process._linkedBinding() + // Set up process.binding() and process._linkedBinding(). { const bindingObj = ObjectCreate(null); @@ -133,7 +133,7 @@ }; } - // Set up internalBinding() in the closure + // Set up internalBinding() in the closure. let internalBinding; { const bindingObj = ObjectCreate(null); @@ -147,10 +147,10 @@ }; } - // Create this WeakMap in js-land because V8 has no C++ API for WeakMap + // Create this WeakMap in js-land because V8 has no C++ API for WeakMap. internalBinding('module_wrap').callbackMap = new WeakMap(); - // Set up NativeModule + // Set up NativeModule. function NativeModule(id) { this.filename = `${id}.js`; this.id = id; @@ -184,7 +184,7 @@ if (!NativeModule.exists(id)) { // Model the error off the internal/errors.js model, but // do not use that module given that it could actually be - // the one causing the error if there's a bug in Node.js + // the one causing the error if there's a bug in Node.js. // eslint-disable-next-line no-restricted-syntax const err = new Error(`No such built-in module: ${id}`); err.code = 'ERR_UNKNOWN_BUILTIN_MODULE'; @@ -225,7 +225,7 @@ if (config.exposeInternals) { NativeModule.nonInternalExists = function(id) { - // Do not expose this to user land even with --expose-internals + // Do not expose this to user land even with --expose-internals. if (id === loaderId) { return false; } @@ -233,7 +233,7 @@ }; NativeModule.isInternal = function(id) { - // Do not expose this to user land even with --expose-internals + // Do not expose this to user land even with --expose-internals. return id === loaderId; }; } else { @@ -267,7 +267,7 @@ }; // Provide named exports for all builtin libraries so that the libraries - // may be imported in a nicer way for esm users. The default export is left + // may be imported in a nicer way for ESM users. The default export is left // as the entire namespace (module.exports) and wrapped in a proxy such // that APMs and other behavior are still left intact. NativeModule.prototype.proxifyExports = function() { @@ -352,7 +352,7 @@ NativeModule._cache[this.id] = this; }; - // coverage must be turned on early, so that we can collect + // Coverage must be turned on early, so that we can collect // it for Node.js' own internal libraries. if (process.env.NODE_V8_COVERAGE) { NativeModule.require('internal/process/coverage').setup();