Permalink
Browse files

fs: remove needless assignment of null

This line `pool = null;` isn't needed and has
been around since the first iteration of streams.
I can't find a good reason for it to exist, it's
not more readable, nor does it seem to trick the
compiler into any optimizations.

PR-URL: #10260
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
  • Loading branch information...
reconbot authored and italoacasas committed Dec 13, 2016
1 parent 15c71f6 commit 1081f0f33df3a6e8825489600967a6f9e469ebb6
Showing with 0 additions and 1 deletion.
  1. +0 −1 lib/fs.js
@@ -1791,7 +1791,6 @@ ReadStream.prototype._read = function(n) {
if (!pool || pool.length - pool.used < kMinPoolSpace) {
// discard the old pool.
pool = null;
allocNewPool(this._readableState.highWaterMark);
}

0 comments on commit 1081f0f

Please sign in to comment.