Skip to content


Browse files Browse the repository at this point in the history
deps: backport 75e43a6 from v8 upstream (again)
Note: When this was cherry-picked for v8 v4.4 (landed in #2636), chunk did not exist. It now exists in
v8 v4.5.103.30. This PR completes the cherry pick of the whole commit
from v8.

PR-URL: #2692
Reviewed-By: ofrobots - Ali Ijaz Sheikh <>

Original commit message:
  Use static_cast<> for NULL (clang 3.7)

  The following errors come up when compiling v8
   with clang 3.7 on FreeBSD/amd64:

  src/runtime/ error: reinterpret_cast from
  'nullptr_t' to 'v8::internal::Smi *' is not allowed
    local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));

  test/cctest/ error: reinterpret_cast from
        'nullptr_t' to 'v8::internal::Object *' is not allowed
    Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
  test/cctest/ error: reinterpret_cast from
        'nullptr_t' to 'Address' (aka 'unsigned char *') is not
    Address base = reinterpret_cast<Address>(NULL);

  +add myself to the AUTHORS file.


  Review URL:

  Cr-Commit-Position: refs/heads/master@{#30103}
  • Loading branch information
saper authored and rvagg committed Sep 6, 2015
1 parent 5652ce0 commit 155783d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deps/v8/test/cctest/
Expand Up @@ -1855,7 +1855,7 @@ TEST(TestAlignmentCalculations) {
CHECK_EQ(maximum_simd128_misalignment, max_simd128_unaligned_fill);

Address base = reinterpret_cast<Address>(NULL);
Address base = static_cast<Address>(NULL);
int fill = 0;

// Word alignment never requires fill.
Expand Down

0 comments on commit 155783d

Please sign in to comment.