From 175f7b60c262697dddd76599699300d9acc859bf Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 18 Dec 2018 17:52:20 -0800 Subject: [PATCH] test: remove unnecessary eslint-disable comments PR-URL: https://github.com/nodejs/node/pull/25119 Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives Reviewed-By: Teddy Katz Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Anna Henningsen --- test/common/wpt.js | 1 - test/js-native-api/test_general/testNapiRun.js | 1 - test/parallel/test-assert-deep.js | 2 +- test/parallel/test-assert.js | 3 --- 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/test/common/wpt.js b/test/common/wpt.js index 2a25a22af53710..de8dd0fc428e4e 100644 --- a/test/common/wpt.js +++ b/test/common/wpt.js @@ -1,4 +1,3 @@ -/* eslint-disable node-core/required-modules */ 'use strict'; const assert = require('assert'); diff --git a/test/js-native-api/test_general/testNapiRun.js b/test/js-native-api/test_general/testNapiRun.js index e322d899ed1ca9..38bfa3a516a018 100644 --- a/test/js-native-api/test_general/testNapiRun.js +++ b/test/js-native-api/test_general/testNapiRun.js @@ -4,7 +4,6 @@ const common = require('../../common'); const assert = require('assert'); // `addon` is referenced through the eval expression in testFile -// eslint-disable-next-line no-unused-vars const addon = require(`./build/${common.buildType}/test_general`); const testCase = '(41.92 + 0.08);'; diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js index ceb17bdf56364d..68b3ee5497db6a 100644 --- a/test/parallel/test-assert-deep.js +++ b/test/parallel/test-assert-deep.js @@ -42,7 +42,7 @@ function re(literals, ...values) { // That is why we discourage using deepEqual in our own tests. // Turn off no-restricted-properties because we are testing deepEqual! -/* eslint-disable no-restricted-properties, prefer-common-expectserror */ +/* eslint-disable no-restricted-properties */ const arr = new Uint8Array([120, 121, 122, 10]); const buf = Buffer.from(arr); diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js index 695d890f4c5f6f..172a55959ec97b 100644 --- a/test/parallel/test-assert.js +++ b/test/parallel/test-assert.js @@ -21,8 +21,6 @@ 'use strict'; -/* eslint-disable node-core/prefer-common-expectserror */ - const common = require('../common'); const assert = require('assert'); const { inspect } = require('util'); @@ -662,7 +660,6 @@ common.expectsError( const tmp = fs.close; fs.close = common.mustCall(tmp, 1); function throwErr() { - // eslint-disable-next-line prefer-assert-methods assert( (Buffer.from('test') instanceof Error) );